Skip to content

feat(rca): add external incident url#193919

Merged
kdelemme merged 4 commits intoelastic:mainfrom
kdelemme:rca/external-links
Sep 25, 2024
Merged

feat(rca): add external incident url#193919
kdelemme merged 4 commits intoelastic:mainfrom
kdelemme:rca/external-links

Conversation

@kdelemme
Copy link
Copy Markdown
Contributor

@kdelemme kdelemme commented Sep 24, 2024

resolves #192589

Summary

This PR adds a simple externalIncidentUrl into the schema and the form. We display the link in the header when provided.

Screenshot
image
image

@kdelemme kdelemme self-assigned this Sep 24, 2024
@obltmachine
Copy link
Copy Markdown

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme added backport:prev-minor v8.16.0 release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Sep 24, 2024
@kdelemme kdelemme marked this pull request as ready for review September 24, 2024 20:05
@kdelemme kdelemme requested a review from a team as a code owner September 24, 2024 20:05
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic Bot added the ci:project-deploy-observability Create an Observability project label Sep 24, 2024
defaultValues: { title: 'New investigation', status: 'triage', tags: [] },
values: investigation ? pick(investigation, ['title', 'status', 'tags']) : undefined,
defaultValues: {
title: 'New investigation',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n

Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kdelemme kdelemme enabled auto-merge (squash) September 25, 2024 13:46
Copy link
Copy Markdown
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 25, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 6cbe446
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193919-6cbe446c91e9

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
investigateApp 562 565 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
investigateApp 465.0KB 466.7KB +1.7KB
observability 467.3KB 467.3KB +25.0B
total +1.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kdelemme kdelemme merged commit 5d51da9 into elastic:main Sep 25, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 25, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 25, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [feat(rca): add external incident url
(#193919)](#193919)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2024-09-25T15:19:11Z","message":"feat(rca):
add external incident url
(#193919)","sha":"5d51da90f626606ef6ea217e4b0be68e85aaa86c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"feat(rca):
add external incident
url","number":193919,"url":"https://github.com/elastic/kibana/pull/193919","mergeCommit":{"message":"feat(rca):
add external incident url
(#193919)","sha":"5d51da90f626606ef6ea217e4b0be68e85aaa86c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193919","number":193919,"mergeCommit":{"message":"feat(rca):
add external incident url
(#193919)","sha":"5d51da90f626606ef6ea217e4b0be68e85aaa86c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
@kdelemme kdelemme deleted the rca/external-links branch September 25, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RCA] "External incident" on investigation (manual only)

7 participants