[Security Solution][Notes] - change order for new flyout notes tab from descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases#193893
Merged
PhilippeOberti merged 1 commit intoelastic:mainfrom Sep 25, 2024
Conversation
…om descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases
PhilippeOberti
added
v9.0.0
Team:Threat Hunting:Investigations
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
added
backport
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
christineweng
approved these changes
Sep 25, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
…om descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases (elastic#193893) (cherry picked from commit eaa0257)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 25, 2024
…tab from descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases (#193893) (#194032) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - change order for new flyout notes tab from descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases (#193893)](#193893) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-09-25T15:29:13Z","message":"[Security Solution][Notes] - change order for new flyout notes tab from descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases (#193893)","sha":"eaa02578f68ccf90520e64ae08485500d5e30b96","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - change order for new flyout notes tab from descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases","number":193893,"url":"https://github.com/elastic/kibana/pull/193893","mergeCommit":{"message":"[Security Solution][Notes] - change order for new flyout notes tab from descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases (#193893)","sha":"eaa02578f68ccf90520e64ae08485500d5e30b96"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193893","number":193893,"mergeCommit":{"message":"[Security Solution][Notes] - change order for new flyout notes tab from descending to ascending (oldest notes to the top) to be consistent with timeline notes and cases (#193893)","sha":"eaa02578f68ccf90520e64ae08485500d5e30b96"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the tiniest change to the expandable flyout notes tab to render the notes from the oldest ones at the top to the newest one at the bottom (opposite to what we have today).
The reason is we want to follow the notes tab in timeline and the way cases comments are ordered in the case details page.