[Inventory][ECO] filter by type on grid#193875
Merged
cauemarcondes merged 2 commits intoelastic:mainfrom Sep 25, 2024
Merged
Conversation
cauemarcondes
added
release_note:skip
botelastic
Bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpatticha
reviewed
Sep 25, 2024
kpatticha
reviewed
Sep 25, 2024
kpatticha
reviewed
Sep 25, 2024
kpatticha
reviewed
Sep 25, 2024
| onFilter: () => void; | ||
| } | ||
|
|
||
| export function BadgeFilterWithPopover({ property, value, onFilter, label }: Props) { |
Contributor
There was a problem hiding this comment.
we can't reuse the component from logs explorer?
Contributor
Author
There was a problem hiding this comment.
That one used in the logs explorer belongs to the Discover plugin. I won't drag myself into refactoring that into a shareable place, at least not for now.
kpatticha
approved these changes
Sep 25, 2024
Contributor
kpatticha
left a comment
kpatticha
left a comment
There was a problem hiding this comment.
Overall looks good to me. Thanks for adding the tests. Added some nits and comments
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 25, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Inventory][ECO] filter by type on grid (#193875)](#193875) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-25T11:40:12Z","message":"[Inventory][ECO] filter by type on grid (#193875)\n\ncloses https://github.com/elastic/kibana/issues/192669\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d8c51a63-6783-4a9c-a785-83004489cd5d","sha":"475fd6c2021ffc79e91afae05fa6793f42a4bb6a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory][ECO] filter by type on grid","number":193875,"url":"https://github.com/elastic/kibana/pull/193875","mergeCommit":{"message":"[Inventory][ECO] filter by type on grid (#193875)\n\ncloses https://github.com/elastic/kibana/issues/192669\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d8c51a63-6783-4a9c-a785-83004489cd5d","sha":"475fd6c2021ffc79e91afae05fa6793f42a4bb6a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193875","number":193875,"mergeCommit":{"message":"[Inventory][ECO] filter by type on grid (#193875)\n\ncloses https://github.com/elastic/kibana/issues/192669\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d8c51a63-6783-4a9c-a785-83004489cd5d","sha":"475fd6c2021ffc79e91afae05fa6793f42a4bb6a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #192669
Screen.Recording.2024-09-24.at.15.mp4