[Security Solution] [Attack discovery] Use common replacements function#193645
Merged
andrew-goldstein merged 1 commit intoelastic:mainfrom Sep 26, 2024
Merged
Conversation
andrew-goldstein
added
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
Author
There was a problem hiding this comment.
acc.replaceAll(key, value) would have been better here (and on line 47 below), though not as good as calling replaceAnonymizedValuesWithOriginalValues
andrew-goldstein
force-pushed
the
use_common_replacements_fn
branch
from
908a44b to
d65ca41
Compare
…nction This PR is a follow-up to <elastic#193428>, to make use of the common function for replacing anonymized values with original values
andrew-goldstein
force-pushed
the
use_common_replacements_fn
branch
from
d65ca41 to
f7eddd6
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
spong
approved these changes
Sep 26, 2024
Member
spong
left a comment
spong
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the cleanup here @andrew-goldstein!
andrew-goldstein
added
backport:version
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…on (elastic#193645) ### [Security Solution] [Attack discovery] Use common replacements function This PR is a follow-up to <elastic#193428>, to make use of the common function for replacing anonymized values with original values (cherry picked from commit 30831e6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…on (elastic#193645) ### [Security Solution] [Attack discovery] Use common replacements function This PR is a follow-up to <elastic#193428>, to make use of the common function for replacing anonymized values with original values (cherry picked from commit 30831e6)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
2 tasks
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
…function (#193645) (#194198) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] [Attack discovery] Use common replacements function (#193645)](#193645) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2024-09-26T17:08:32Z","message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.15.3"],"title":"[Security Solution] [Attack discovery] Use common replacements function","number":193645,"url":"https://github.com/elastic/kibana/pull/193645","mergeCommit":{"message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193645","number":193645,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
… function (#193645) (#194197) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution] [Attack discovery] Use common replacements function (#193645)](#193645) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2024-09-26T17:08:32Z","message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.15.3"],"title":"[Security Solution] [Attack discovery] Use common replacements function","number":193645,"url":"https://github.com/elastic/kibana/pull/193645","mergeCommit":{"message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193645","number":193645,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Sep 30, 2024
…page error This PR fixes an `Unable to load page error` in the Security Assistant, introduced in <elastic#193645>, where a check that appeared to be optional was removed. - The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?` - After the error occurs, re-opening the assistant for the same conversation may re-trigger the error - As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:  ### Steps to reproduce To reproduce: 1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?` **Expected result** - Anonymized alerts are displayed **Actual result** - An `Unable to load page` error is displayed, as illustrated by the screenshot below:  - The error details include text similar to the output below: ``` TypeError: Cannot convert undefined or null to object at Function.keys (<anonymous>) at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14) at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158) at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41) at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32 at Array.map (<anonymous>) at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45) at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15 at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19) at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16) The above error occurred in AssistantComponent: at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3) at div at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73 at div at http://loc ``` - The following video illustrates the error: <https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1> s
andrew-goldstein
added a commit
that referenced
this pull request
Oct 1, 2024
… error in the Security assistant (#194488) ### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant This PR fixes an `Unable to load page error` in the Security Assistant, introduced in <#193645>, where a check that appeared to be optional was removed. - The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?` - After the error occurs, re-opening the assistant for the same conversation may re-trigger the error - As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:  ### Steps to reproduce To reproduce: 1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?` **Expected result** - Anonymized alerts are displayed **Actual result** - An `Unable to load page` error is displayed, as illustrated by the screenshot below:  - The error details include text similar to the output below: ``` TypeError: Cannot convert undefined or null to object at Function.keys (<anonymous>) at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14) at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158) at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41) at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32 at Array.map (<anonymous>) at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45) at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15 at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19) at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16) The above error occurred in AssistantComponent: at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3) at div at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73 at div at http://loc ``` - The following video illustrates the error: <https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
… error in the Security assistant (elastic#194488) ### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant This PR fixes an `Unable to load page error` in the Security Assistant, introduced in <elastic#193645>, where a check that appeared to be optional was removed. - The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?` - After the error occurs, re-opening the assistant for the same conversation may re-trigger the error - As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:  ### Steps to reproduce To reproduce: 1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?` **Expected result** - Anonymized alerts are displayed **Actual result** - An `Unable to load page` error is displayed, as illustrated by the screenshot below:  - The error details include text similar to the output below: ``` TypeError: Cannot convert undefined or null to object at Function.keys (<anonymous>) at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14) at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158) at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41) at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32 at Array.map (<anonymous>) at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45) at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15 at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19) at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16) The above error occurred in AssistantComponent: at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3) at div at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73 at div at http://loc ``` - The following video illustrates the error: <https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1> (cherry picked from commit 35233ba)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
… error in the Security assistant (elastic#194488) ### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant This PR fixes an `Unable to load page error` in the Security Assistant, introduced in <elastic#193645>, where a check that appeared to be optional was removed. - The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?` - After the error occurs, re-opening the assistant for the same conversation may re-trigger the error - As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:  ### Steps to reproduce To reproduce: 1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?` **Expected result** - Anonymized alerts are displayed **Actual result** - An `Unable to load page` error is displayed, as illustrated by the screenshot below:  - The error details include text similar to the output below: ``` TypeError: Cannot convert undefined or null to object at Function.keys (<anonymous>) at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14) at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158) at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41) at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32 at Array.map (<anonymous>) at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45) at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15 at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19) at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16) The above error occurred in AssistantComponent: at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3) at div at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73 at div at http://loc ``` - The following video illustrates the error: <https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1> (cherry picked from commit 35233ba)
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
…ad page error in the Security assistant (#194488) (#194506) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488)](#194488) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2024-10-01T00:49:52Z","message":"[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488)\n\n### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant\r\n\r\nThis PR fixes an `Unable to load page error` in the Security Assistant, introduced in <#193645>, where a check that appeared to be optional was removed.\r\n\r\n- The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?`\r\n- After the error occurs, re-opening the assistant for the same conversation may re-trigger the error\r\n- As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:\r\n\r\n\r\n\r\n### Steps to reproduce\r\n\r\nTo reproduce:\r\n\r\n1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?`\r\n\r\n**Expected result**\r\n\r\n- Anonymized alerts are displayed\r\n\r\n**Actual result**\r\n\r\n- An `Unable to load page` error is displayed, as illustrated by the screenshot below:\r\n\r\n\r\n\r\n- The error details include text similar to the output below:\r\n\r\n```\r\nTypeError: Cannot convert undefined or null to object\r\n at Function.keys (<anonymous>)\r\n at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14)\r\n at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158)\r\n at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32\r\n at Array.map (<anonymous>)\r\n at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15\r\n at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19)\r\n at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16)\r\n\r\n\r\nThe above error occurred in AssistantComponent:\r\n at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3)\r\n at div\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73\r\n at div\r\n at http://loc\r\n```\r\n\r\n- The following video illustrates the error:\r\n\r\n<https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1>","sha":"35233ba890558a8251b71a0fba33d8f42fae662d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.15.3"],"title":"[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant","number":194488,"url":"https://github.com/elastic/kibana/pull/194488","mergeCommit":{"message":"[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488)\n\n### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant\r\n\r\nThis PR fixes an `Unable to load page error` in the Security Assistant, introduced in <#193645>, where a check that appeared to be optional was removed.\r\n\r\n- The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?`\r\n- After the error occurs, re-opening the assistant for the same conversation may re-trigger the error\r\n- As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:\r\n\r\n\r\n\r\n### Steps to reproduce\r\n\r\nTo reproduce:\r\n\r\n1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?`\r\n\r\n**Expected result**\r\n\r\n- Anonymized alerts are displayed\r\n\r\n**Actual result**\r\n\r\n- An `Unable to load page` error is displayed, as illustrated by the screenshot below:\r\n\r\n\r\n\r\n- The error details include text similar to the output below:\r\n\r\n```\r\nTypeError: Cannot convert undefined or null to object\r\n at Function.keys (<anonymous>)\r\n at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14)\r\n at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158)\r\n at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32\r\n at Array.map (<anonymous>)\r\n at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15\r\n at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19)\r\n at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16)\r\n\r\n\r\nThe above error occurred in AssistantComponent:\r\n at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3)\r\n at div\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73\r\n at div\r\n at http://loc\r\n```\r\n\r\n- The following video illustrates the error:\r\n\r\n<https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1>","sha":"35233ba890558a8251b71a0fba33d8f42fae662d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194488","number":194488,"mergeCommit":{"message":"[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488)\n\n### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant\r\n\r\nThis PR fixes an `Unable to load page error` in the Security Assistant, introduced in <#193645>, where a check that appeared to be optional was removed.\r\n\r\n- The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?`\r\n- After the error occurs, re-opening the assistant for the same conversation may re-trigger the error\r\n- As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:\r\n\r\n\r\n\r\n### Steps to reproduce\r\n\r\nTo reproduce:\r\n\r\n1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?`\r\n\r\n**Expected result**\r\n\r\n- Anonymized alerts are displayed\r\n\r\n**Actual result**\r\n\r\n- An `Unable to load page` error is displayed, as illustrated by the screenshot below:\r\n\r\n\r\n\r\n- The error details include text similar to the output below:\r\n\r\n```\r\nTypeError: Cannot convert undefined or null to object\r\n at Function.keys (<anonymous>)\r\n at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14)\r\n at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158)\r\n at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32\r\n at Array.map (<anonymous>)\r\n at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15\r\n at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19)\r\n at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16)\r\n\r\n\r\nThe above error occurred in AssistantComponent:\r\n at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3)\r\n at div\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73\r\n at div\r\n at http://loc\r\n```\r\n\r\n- The following video illustrates the error:\r\n\r\n<https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1>","sha":"35233ba890558a8251b71a0fba33d8f42fae662d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
…d page error in the Security assistant (#194488) (#194507) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488)](#194488) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2024-10-01T00:49:52Z","message":"[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488)\n\n### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant\r\n\r\nThis PR fixes an `Unable to load page error` in the Security Assistant, introduced in <#193645>, where a check that appeared to be optional was removed.\r\n\r\n- The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?`\r\n- After the error occurs, re-opening the assistant for the same conversation may re-trigger the error\r\n- As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:\r\n\r\n\r\n\r\n### Steps to reproduce\r\n\r\nTo reproduce:\r\n\r\n1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?`\r\n\r\n**Expected result**\r\n\r\n- Anonymized alerts are displayed\r\n\r\n**Actual result**\r\n\r\n- An `Unable to load page` error is displayed, as illustrated by the screenshot below:\r\n\r\n\r\n\r\n- The error details include text similar to the output below:\r\n\r\n```\r\nTypeError: Cannot convert undefined or null to object\r\n at Function.keys (<anonymous>)\r\n at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14)\r\n at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158)\r\n at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32\r\n at Array.map (<anonymous>)\r\n at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15\r\n at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19)\r\n at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16)\r\n\r\n\r\nThe above error occurred in AssistantComponent:\r\n at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3)\r\n at div\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73\r\n at div\r\n at http://loc\r\n```\r\n\r\n- The following video illustrates the error:\r\n\r\n<https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1>","sha":"35233ba890558a8251b71a0fba33d8f42fae662d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.15.3"],"title":"[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant","number":194488,"url":"https://github.com/elastic/kibana/pull/194488","mergeCommit":{"message":"[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488)\n\n### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant\r\n\r\nThis PR fixes an `Unable to load page error` in the Security Assistant, introduced in <#193645>, where a check that appeared to be optional was removed.\r\n\r\n- The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?`\r\n- After the error occurs, re-opening the assistant for the same conversation may re-trigger the error\r\n- As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:\r\n\r\n\r\n\r\n### Steps to reproduce\r\n\r\nTo reproduce:\r\n\r\n1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?`\r\n\r\n**Expected result**\r\n\r\n- Anonymized alerts are displayed\r\n\r\n**Actual result**\r\n\r\n- An `Unable to load page` error is displayed, as illustrated by the screenshot below:\r\n\r\n\r\n\r\n- The error details include text similar to the output below:\r\n\r\n```\r\nTypeError: Cannot convert undefined or null to object\r\n at Function.keys (<anonymous>)\r\n at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14)\r\n at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158)\r\n at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32\r\n at Array.map (<anonymous>)\r\n at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15\r\n at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19)\r\n at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16)\r\n\r\n\r\nThe above error occurred in AssistantComponent:\r\n at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3)\r\n at div\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73\r\n at div\r\n at http://loc\r\n```\r\n\r\n- The following video illustrates the error:\r\n\r\n<https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1>","sha":"35233ba890558a8251b71a0fba33d8f42fae662d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194488","number":194488,"mergeCommit":{"message":"[Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488)\n\n### [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant\r\n\r\nThis PR fixes an `Unable to load page error` in the Security Assistant, introduced in <#193645>, where a check that appeared to be optional was removed.\r\n\r\n- The issue occurs when the assistant is asked a question that is likely to require anonymization, for example: `which alerts should I look at first?`\r\n- After the error occurs, re-opening the assistant for the same conversation may re-trigger the error\r\n- As a workaround, clear Kibana local storage for the current user, or via the browser's dev tools, specifically delete the `elasticAssistantDefault.lastConversationId` setting illustrated by the screenshot below:\r\n\r\n\r\n\r\n### Steps to reproduce\r\n\r\nTo reproduce:\r\n\r\n1) Ask the assistant a question that is likely to cause anonymized alerts to be returned, for example: `which alerts should I look at first?`\r\n\r\n**Expected result**\r\n\r\n- Anonymized alerts are displayed\r\n\r\n**Actual result**\r\n\r\n- An `Unable to load page` error is displayed, as illustrated by the screenshot below:\r\n\r\n\r\n\r\n- The error details include text similar to the output below:\r\n\r\n```\r\nTypeError: Cannot convert undefined or null to object\r\n at Function.keys (<anonymous>)\r\n at replaceAnonymizedValuesWithOriginalValues (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:60965:14)\r\n at transformMessageWithReplacements (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100511:158)\r\n at transformMessage (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100612:41)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100638:32\r\n at Array.map (<anonymous>)\r\n at getComments (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:100595:45)\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68997:15\r\n at updateMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:369829:19)\r\n at Object.useMemo (http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:370375:16)\r\n\r\n\r\nThe above error occurred in AssistantComponent:\r\n at AssistantComponent (http://localhost:5601/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.lazy_application_dependencies.js:68776:3)\r\n at div\r\n at http://localhost:5601/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:160008:73\r\n at div\r\n at http://loc\r\n```\r\n\r\n- The following video illustrates the error:\r\n\r\n<https://github.com/user-attachments/assets/e96d7ac0-032d-49d6-88be-a8add6547fb1>","sha":"35233ba890558a8251b71a0fba33d8f42fae662d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Security Solution] [Attack discovery] Use common replacements function
This PR is a follow-up to #193428, to make use of the common function for replacing anonymized values with original values