[Discover] Add "Shift + Select" functionality to Discover grid#193619
Merged
jughosta merged 5 commits intoelastic:mainfrom Sep 25, 2024
Merged
[Discover] Add "Shift + Select" functionality to Discover grid#193619jughosta merged 5 commits intoelastic:mainfrom
jughosta merged 5 commits intoelastic:mainfrom
Conversation
jughosta
added
release_note:enhancement
Team:DataDiscovery
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
approved these changes
Sep 24, 2024
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Awesome, I love it! So much more convenient than selecting individual documents or pages only. Works great for keyboard users too 👍
logeekal
approved these changes
Sep 25, 2024
Contributor
logeekal
left a comment
logeekal
left a comment
There was a problem hiding this comment.
LGTM from investigations side. This is a great UX improvement. Thanks.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
…ic#193619) - Closes elastic#192366 ## Summary This PR allows to select/deselect multiple rows by holding SHIFT key when toggling row checkboxes. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 6808f82)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 25, 2024
…over grid (#193619) (#193955) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Add "Shift + Select" functionality to Discover grid (#193619)](#193619) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-09-25T09:38:49Z","message":"[Discover] Add \"Shift + Select\" functionality to Discover grid (#193619)\n\n- Closes https://github.com/elastic/kibana/issues/192366\r\n\r\n## Summary\r\n\r\nThis PR allows to select/deselect multiple rows by holding SHIFT key\r\nwhen toggling row checkboxes.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"6808f826625f7f901099df6360a2f5e7edc21ab4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:UnifiedDataTable","Project:OneDiscover"],"title":"[Discover] Add \"Shift + Select\" functionality to Discover grid","number":193619,"url":"https://github.com/elastic/kibana/pull/193619","mergeCommit":{"message":"[Discover] Add \"Shift + Select\" functionality to Discover grid (#193619)\n\n- Closes https://github.com/elastic/kibana/issues/192366\r\n\r\n## Summary\r\n\r\nThis PR allows to select/deselect multiple rows by holding SHIFT key\r\nwhen toggling row checkboxes.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"6808f826625f7f901099df6360a2f5e7edc21ab4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193619","number":193619,"mergeCommit":{"message":"[Discover] Add \"Shift + Select\" functionality to Discover grid (#193619)\n\n- Closes https://github.com/elastic/kibana/issues/192366\r\n\r\n## Summary\r\n\r\nThis PR allows to select/deselect multiple rows by holding SHIFT key\r\nwhen toggling row checkboxes.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"6808f826625f7f901099df6360a2f5e7edc21ab4"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows to select/deselect multiple rows by holding SHIFT key when toggling row checkboxes.
Checklist