Skip to content

[ES|QL] Renames the language package to a more generic name#193517

Merged
stratoula merged 4 commits intoelastic:mainfrom
stratoula:language-documentation-rename
Sep 23, 2024
Merged

[ES|QL] Renames the language package to a more generic name#193517
stratoula merged 4 commits intoelastic:mainfrom
stratoula:language-documentation-rename

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Sep 20, 2024

Summary

Renames the language-documentation-popover to language-documentation as it stores additional layouts:

  • popover
  • flyout
  • inline

@stratoula stratoula changed the title [ES|QL] Rename the language package to a more generic one [ES|QL] Renames the language package to a more generic one Sep 20, 2024
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting backport:prev-minor Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.0.0 v8.16.0 and removed backport:skip This PR does not require backporting labels Sep 20, 2024
@stratoula stratoula marked this pull request as ready for review September 20, 2024 10:27
@stratoula stratoula requested review from a team as code owners September 20, 2024 10:27
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula changed the title [ES|QL] Renames the language package to a more generic one [ES|QL] Renames the language package to a more generic name Sep 20, 2024
Copy link
Copy Markdown
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/dev/storybook/aliases.ts

Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCSS

@stratoula
Copy link
Copy Markdown
Contributor Author

/ci

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/language-documentation - 7 +7
@kbn/language-documentation-popover 7 - -7
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 174.9KB 172.9KB -1.9KB
lens 1.5MB 1.5MB -28.0B
unifiedSearch 343.5KB 341.6KB -1.9KB
total -3.9KB
Unknown metric groups

API count

id before after diff
@kbn/language-documentation - 11 +11
@kbn/language-documentation-popover 11 - -11
total -0

ESLint disabled line counts

id before after diff
@kbn/language-documentation - 1 +1
@kbn/language-documentation-popover 1 - -1
total -0

Total ESLint disabled count

id before after diff
@kbn/language-documentation - 1 +1
@kbn/language-documentation-popover 1 - -1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 9d0d41c into elastic:main Sep 23, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Data Usage] New plugin (#193466)
- [ML] Anomaly Explorer: Hide top influencers panel for jobs without influencers (#192987)
- [Response Ops][Rules] Rule Model Version Forward Compat (#193233)

Manual backport

To create the backport manually run:

node scripts/backport --pr 193517

Questions ?

Please refer to the Backport tool documentation

@stratoula
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request Sep 23, 2024
…193517)

## Summary

Renames the language-documentation-popover to language-documentation as
it stores additional layouts:
- popover
- flyout
- inline

(cherry picked from commit 9d0d41c)

# Conflicts:
#	.github/CODEOWNERS
stratoula added a commit that referenced this pull request Sep 23, 2024
…93517) (#193691)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Renames the language package to a more generic name
(#193517)](#193517)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-09-23T07:58:53Z","message":"[ES|QL]
Renames the language package to a more generic name (#193517)\n\n##
Summary\r\n\r\nRenames the language-documentation-popover to
language-documentation as\r\nit stores additional layouts:\r\n-
popover\r\n- flyout\r\n-
inline","sha":"9d0d41ce871be49f4d18b8bbfad7791173c6ebc8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"number":193517,"url":"https://github.com/elastic/kibana/pull/193517","mergeCommit":{"message":"[ES|QL]
Renames the language package to a more generic name (#193517)\n\n##
Summary\r\n\r\nRenames the language-documentation-popover to
language-documentation as\r\nit stores additional layouts:\r\n-
popover\r\n- flyout\r\n-
inline","sha":"9d0d41ce871be49f4d18b8bbfad7791173c6ebc8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193517","number":193517,"mergeCommit":{"message":"[ES|QL]
Renames the language package to a more generic name (#193517)\n\n##
Summary\r\n\r\nRenames the language-documentation-popover to
language-documentation as\r\nit stores additional layouts:\r\n-
popover\r\n- flyout\r\n-
inline","sha":"9d0d41ce871be49f4d18b8bbfad7791173c6ebc8"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants