Skip to content

[Unified Search] Remove soon-to-be-deprecated EuiFormControl Sass mixins #193472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ikuni17 merged 4 commits into from
Sep 24, 2024
Merged

[Unified Search] Remove soon-to-be-deprecated EuiFormControl Sass mixins #193472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d21efe7
Replace `euiFormControl` Sass mixins with Sass variables instead
cee-chen Sep 19, 2024
43b467b
[misc] Remove unnecessary `resize` CSS override, use prop instead
cee-chen Sep 19, 2024
2140468
[misc] Newline linting
cee-chen Sep 19, 2024
3757479
Merge branch 'main' into eui-kbn-query-bar-cleanup
cee-chen Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions src/plugins/unified_search/public/query_string_input/query_string_input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,20 @@

.kbnQueryBar__textarea {
z-index: $euiZContentMenu;
resize: none !important; // When in the group, it will autosize
height: $euiFormControlHeight;
// Unlike most inputs within layout control groups, the text area still needs a border
// for multi-line content. These adjusts help it sit above the control groups
// shadow to line up correctly.
padding: ($euiSizeS + 2px) $euiSizeS $euiSizeS;
padding: $euiSizeS;
padding-top: $euiSizeS + 2px;
padding-left: $euiSizeXXL; // Account for search icon
// Firefox adds margin to textarea
margin: 0;

&--isClearable {
padding-right: $euiSizeXXL; // Account for clear button
}

&:not(.kbnQueryBar__textarea--autoHeight) {
overflow-y: hidden;
overflow-x: hidden;
Expand All @@ -38,20 +43,13 @@
overflow-x: auto;
overflow-y: auto;
white-space: normal;

}

&.kbnQueryBar__textarea--isSuggestionsVisible {
border-bottom-right-radius: 0;
border-bottom-left-radius: 0;
}

&--isClearable {
@include euiFormControlWithIcon($isIconOptional: false, $side: 'right');
}

@include euiFormControlWithIcon($isIconOptional: true);

~.euiFormControlLayoutIcons {
// By default form control layout icon is vertically centered, but our textarea
// can expand to be multi-line, so we position it with padding that matches
Expand All @@ -67,4 +65,4 @@
margin-left: -1px;
width: calc(100% + 1px);
}
}
}
1 change: 1 addition & 0 deletions src/plugins/unified_search/public/query_string_input/query_string_input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,6 +830,7 @@ export default class QueryStringInputUI extends PureComponent<QueryStringInputPr
disabled={this.props.isDisabled}
className={inputClassName}
fullWidth
resize="none"
rows={1}
id={this.textareaId}
autoFocus={
Expand Down