Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/kbn-esql-utils/src/utils/append_to_query.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,5 +168,11 @@ AND \`dest\`=="Crete"`
and \`ip\`::string!="127.0.0.2/32"`
);
});

it('returns undefined for multivalue fields', () => {
expect(
appendWhereClauseToESQLQuery('from logstash-*', 'dest', ['meow'], '+', 'string')
).toBeUndefined();
});
});
});
6 changes: 5 additions & 1 deletion packages/kbn-esql-utils/src/utils/append_to_query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ export function appendWhereClauseToESQLQuery(
value: unknown,
operation: '+' | '-' | 'is_not_null' | 'is_null',
fieldType?: string
): string {
): string | undefined {
// multivalues filtering is not supported yet
if (Array.isArray(value)) {
return undefined;
}
let operator;
switch (operation) {
case 'is_not_null':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ export function DiscoverLayout({ stateContainer }: DiscoverLayoutProps) {
getOperator(fieldName, values, operation),
fieldType
);
if (!updatedQuery) {
return;
}
data.query.queryString.setQuery({
esql: updatedQuery,
});
Expand Down