Skip to content

CP-7781 - switching bk pipeline to gpctl promote after synthetics #193411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mduarte merged 7 commits into from
Sep 25, 2024
Merged

CP-7781 - switching bk pipeline to gpctl promote after synthetics #193411

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
47ebb1b
CP-7781 - switching bk pipeline to gpctl promote after synthetics
mduarte Sep 19, 2024
e413e5a
Merge branch 'main' into CP-7781/gpctl-promote-synthetics
mduarte Sep 20, 2024
f150dea
Merge branch 'main' into CP-7781/gpctl-promote-synthetics
mduarte Sep 22, 2024
580ccab
[CI] Auto-commit changed files from 'make api-docs && make api-docs-s…
kibanamachine Sep 22, 2024
31cce20
Add support for DRY_RUN
mduarte Sep 25, 2024
c71d908
Merge branch 'main' into CP-7781/gpctl-promote-synthetics
mduarte Sep 25, 2024
ff83b2e
Merge branch 'main' into CP-7781/gpctl-promote-synthetics
jbudz Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .buildkite/scripts/steps/artifacts/docker_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,15 @@ steps:
env:
CONTAINER: "$KIBANA_IMAGE"
soft_fail: true
- label: ":argo: Update kibana image tag for kibana-controller using gpctl"
- label: ":serverless::argo: Run synthetics tests and update kibana image tag to ${GIT_ABBREV_COMMIT} for kibana-controller"
branches: main
trigger: gpctl-promote-with-e2e-tests
trigger: gpctl-promote-after-serverless-devenv-synthetics
build:
env:
SERVICE_COMMIT_HASH: "$GIT_ABBREV_COMMIT"
SERVICE: kibana
REMOTE_SERVICE_CONFIG: https://raw.githubusercontent.com/elastic/serverless-gitops/main/gen/gpctl/kibana/dev.yaml
DRY_RUN: "${DRY_RUN:-false}"
Copy link
Copy Markdown
Contributor

@jbudz jbudz Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer available? It was previously helpful for us to run this pipeline without promoting artifacts in support of testing pipeline changes on our side.

Copy link
Copy Markdown
Contributor Author

@mduarte mduarte Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality was also not available in the previous pipeline.

Out of curiosity, have you tried to call this recently with DRY_RUN=true?
We do have a separate pipeline that only does the testing and no promotion.

Copy link
Copy Markdown
Contributor

@jbudz jbudz Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly not involved with the Kibana release pipeline, not sure how this was used.

@pheyos @delanni can you take a look?

Copy link
Copy Markdown
Member

@delanni delanni Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used this flag while testing the migrations to ensure we triggered the right downstream. I don't know if it's still in use, or would have future uses.

For more context, we added the Kibana triggers here: https://github.com/elastic/kibana/pull/178658/files

the corresponding escape hatch was added to promote.sh here: https://github.com/elastic/gpctl/pull/261

It's true, that the gpctl-promote-with-e2e-tests pipeline didn't have a reference to DRY_RUN, but I believe, it did work for our case using the gpctl-promote pipeline, as we directly triggered that (and thus the env section from the first linked PR was passed on). Through gpctl-promote-with-e2e-tests this is probably lost, unless we pass along the env to the trigger step.

I don't think we're using the DRY_RUN for any other use cases right now. So we can either add env passing there, or allow this to be removed for now. I'd go for the first option, since the hatch exists in promote.sh, we may as well expose it.

Copy link
Copy Markdown
Contributor Author

@mduarte mduarte Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added support for a more explicit env variable called GPCTL_PROMOTE_DRY_RUN in https://github.com/elastic/serverless-gitops/pull/4202.

GPCTL_PROMOTE_DRY_RUN: ${DRY_RUN:-false}
EOF

else
Expand Down