Refactoring Inference Management UI#193380
Merged
Samiul-TheSoccerFan merged 9 commits intoelastic:mainfrom Sep 19, 2024
Merged
Conversation
efegurkan
approved these changes
Sep 19, 2024
Member
efegurkan
left a comment
efegurkan
left a comment
There was a problem hiding this comment.
LGTM, I have a question for me to understand otherwise
Code review only
| }, | ||
| sortable: true, | ||
| truncateText: true, | ||
| width: '400px', |
Member
There was a problem hiding this comment.
nitpick(non-blocking): if possible can we calculate them as euiTheme base size * quotient.
| }; | ||
| }); | ||
| }, [inferenceEndpoints, searchKey, filterOptions, deploymentStatus]); | ||
| .map((endpoint) => ({ |
Member
There was a problem hiding this comment.
Doing a code only review, looks good, but I have to ask something to understand.
Did the data changed or are you using different fields only?
Contributor
Author
There was a problem hiding this comment.
The API calls will still get the same data however with these changes, we are updating how the data got presented
in the Table View.
Contributor
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
## Summary This PR includes: - Adding header links and text - Restructure of columns - Increased pagination limit  ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit fd149a5)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 19, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Refactoring Inference Management UI (#193380)](#193380) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-19T21:33:28Z","message":"Refactoring Inference Management UI (#193380)\n\n## Summary\r\n\r\nThis PR includes:\r\n- Adding header links and text\r\n- Restructure of columns\r\n- Increased pagination limit\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"fd149a5ab2c935d9f8f2dfe17c7f35c8a1c1f353","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:fix","v9.0.0","Team:Search","v8.16.0"],"title":"Refactoring Inference Management UI","number":193380,"url":"https://github.com/elastic/kibana/pull/193380","mergeCommit":{"message":"Refactoring Inference Management UI (#193380)\n\n## Summary\r\n\r\nThis PR includes:\r\n- Adding header links and text\r\n- Restructure of columns\r\n- Increased pagination limit\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"fd149a5ab2c935d9f8f2dfe17c7f35c8a1c1f353"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193380","number":193380,"mergeCommit":{"message":"Refactoring Inference Management UI (#193380)\n\n## Summary\r\n\r\nThis PR includes:\r\n- Adding header links and text\r\n- Restructure of columns\r\n- Increased pagination limit\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"fd149a5ab2c935d9f8f2dfe17c7f35c8a1c1f353"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Samiul Monir <150824886+Samiul-TheSoccerFan@users.noreply.github.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes:
Checklist
Delete any items that are not applicable to this PR.