Update kbn-flot-charts codeowners#193351
Merged
jbudz merged 3 commits intoelastic:mainfrom Sep 25, 2024
Merged
Conversation
jbudz
added
Team:Monitoring
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Ikuni17
approved these changes
Sep 18, 2024
dej611
requested changes
Sep 19, 2024
Comment on lines
+4
to
+8
| "owner": [ | ||
| "@elastic/kibana-presentation", | ||
| "@elastic/kibana-visualizations", | ||
| "@elastic/stack-monitoring", | ||
| ] |
Contributor
There was a problem hiding this comment.
Suggested change
| "owner": [ | |
| "@elastic/kibana-presentation", | |
| "@elastic/kibana-visualizations", | |
| "@elastic/stack-monitoring", | |
| ] | |
| "owner": [ | |
| "@elastic/kibana-presentation", | |
| "@elastic/stack-monitoring", | |
| ] |
The visualization team doesn't use this package any more.
| packages/kbn-find-used-node-modules @elastic/kibana-operations | ||
| x-pack/plugins/fleet @elastic/fleet | ||
| packages/kbn-flot-charts @elastic/kibana-operations | ||
| packages/kbn-flot-charts @elastic/kibana-presentation @elastic/kibana-visualizations @elastic/stack-monitoring |
Contributor
There was a problem hiding this comment.
Suggested change
| packages/kbn-flot-charts @elastic/kibana-presentation @elastic/kibana-visualizations @elastic/stack-monitoring | |
| packages/kbn-flot-charts @elastic/kibana-presentation @elastic/stack-monitoring |
dej611
approved these changes
Sep 19, 2024
💛 Build succeeded, but was flaky
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As best I can tell this was default assigned to operations during a large refactor - #138965.
Operations is mostly disconnected from the UI. I'm proposing transferring this over to area teams where flot is in use - stack monitoring, canvas, and timelion.