Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [dashboard] Lazy DashboardRenderer (#192754) #193219

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 17, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese nreese enabled auto-merge (squash) September 17, 2024 19:31
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Feature:Embedding Embedding content via iFrame Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Sep 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 17, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: fc5932a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193219-fc5932aac93e

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 561 562 +1
securitySolution 5759 5792 +33
total +34

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +17.0B
dashboard 457.3KB 481.2KB +23.9KB
infra 1.6MB 1.6MB -8.0B
securitySolution 20.3MB 20.3MB +315.0B
total +24.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dashboard 12 13 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 42.4KB 26.9KB -15.5KB
Unknown metric groups

API count

id before after diff
dashboard 129 128 -1

async chunk count

id before after diff
dashboard 14 15 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nreese nreese merged commit 79cb9c5 into elastic:8.x Sep 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Feature:Embedding Embedding content via iFrame Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants