[Console] Regenerate autocomplete definitions for 8.15 #193208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
added
Feature:Console
sabarasaba
added
the
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
sabarasaba
reviewed
Sep 18, 2024
| "patterns": [ | ||
| "_ingest/geoip/database/{id}" | ||
| ], | ||
| "documentation": "https://www.elastic.co/guide/en/elasticsearch/reference/master/TODO.html", |
There was a problem hiding this comment.
Do we still not have docs for these API's (delete, get, put)? Wonder if we should still show the documentation link at all in that case since it points to a 404 page
There was a problem hiding this comment.
Great catch, thanks! This is actually a typo in the Elasticsearch repo, I opened elastic/elasticsearch#113082 to fix it. To get it fixed here, the normal way is:
- fix it in Elasticsearch
- wait or trigger the daily sync to the Elasticsearch specification
- then run the Kibana generate_console_definitions.js script.
That's a lot! In the interest on not blocking this pull request, I have fixed the URLs in 5bc5c77 (#193208).
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 18, 2024
## Summary This regenerates the autocomplete definitions using the current 8.15 branch of the Elasticsearch specification. More specifically: * Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not sure why this was not applied already) * Update `format` for `esql.query` to include `arrow` (and remove the corresponding override) * Add three new Ingest GeoIP APIs and 3 Security APIs * Remove a number of unused/harmful query parameter overrides (cherry picked from commit e5299a5)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 18, 2024
#193283) # Backport This will backport the following commits from `main` to `8.x`: - [[Console] Regenerate autocomplete definitions for 8.15 (#193208)](#193208) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Quentin Pradet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-18T12:13:10Z","message":"[Console] Regenerate autocomplete definitions for 8.15 (#193208)\n\n## Summary\r\n\r\nThis regenerates the autocomplete definitions using the current 8.15\r\nbranch of the Elasticsearch specification. More specifically:\r\n\r\n* Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not\r\nsure why this was not applied already)\r\n* Update `format` for `esql.query` to include `arrow` (and remove the\r\ncorresponding override)\r\n * Add three new Ingest GeoIP APIs and 3 Security APIs\r\n * Remove a number of unused/harmful query parameter overrides","sha":"e5299a562e6a5e5071bed69b422df549d990d578","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","v8.16.0","backport:version","v8.15.2"],"title":"[Console] Regenerate autocomplete definitions for 8.15","number":193208,"url":"#193208 Regenerate autocomplete definitions for 8.15 (#193208)\n\n## Summary\r\n\r\nThis regenerates the autocomplete definitions using the current 8.15\r\nbranch of the Elasticsearch specification. More specifically:\r\n\r\n* Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not\r\nsure why this was not applied already)\r\n* Update `format` for `esql.query` to include `arrow` (and remove the\r\ncorresponding override)\r\n * Add three new Ingest GeoIP APIs and 3 Security APIs\r\n * Remove a number of unused/harmful query parameter overrides","sha":"e5299a562e6a5e5071bed69b422df549d990d578"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#193208 Regenerate autocomplete definitions for 8.15 (#193208)\n\n## Summary\r\n\r\nThis regenerates the autocomplete definitions using the current 8.15\r\nbranch of the Elasticsearch specification. More specifically:\r\n\r\n* Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not\r\nsure why this was not applied already)\r\n* Update `format` for `esql.query` to include `arrow` (and remove the\r\ncorresponding override)\r\n * Add three new Ingest GeoIP APIs and 3 Security APIs\r\n * Remove a number of unused/harmful query parameter overrides","sha":"e5299a562e6a5e5071bed69b422df549d990d578"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Quentin Pradet <[email protected]>
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Sep 18, 2024
## Summary This regenerates the autocomplete definitions using the current 8.15 branch of the Elasticsearch specification. More specifically: * Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not sure why this was not applied already) * Update `format` for `esql.query` to include `arrow` (and remove the corresponding override) * Add three new Ingest GeoIP APIs and 3 Security APIs * Remove a number of unused/harmful query parameter overrides
pquentin
added a commit
to pquentin/kibana
that referenced
this pull request
Sep 19, 2024
This regenerates the autocomplete definitions using the current 8.15 branch of the Elasticsearch specification. More specifically: * Rename `query_rules` APIs to `query_ruleset` as was done in 8.15 (not sure why this was not applied already) * Update `format` for `esql.query` to include `arrow` (and remove the corresponding override) * Add three new Ingest GeoIP APIs and 3 Security APIs * Remove a number of unused/harmful query parameter overrides (cherry picked from commit e5299a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This regenerates the autocomplete definitions using the current 8.15 branch of the Elasticsearch specification. More specifically:
query_rulesAPIs toquery_rulesetas was done in 8.15 (not sure why this was not applied already)formatforesql.queryto includearrow(and remove the corresponding override)This screenshot shows that
arrowis correctly included foresql.query:For maintainers