-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17] Upgrade express 4.19.2→4.21.0 (#192862) #193130
Merged
jeramysoucy
merged 4 commits into
elastic:7.17
from
jeramysoucy:backport/7.17/pr-192862
Sep 17, 2024
Merged
[7.17] Upgrade express 4.19.2→4.21.0 (#192862) #193130
jeramysoucy
merged 4 commits into
elastic:7.17
from
jeramysoucy:backport/7.17/pr-192862
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Upgrades `express` from v4.19.2 to v4.21.0, and `@types/express` from v4.17.13 to v4.17.21. This PR also moves the dev-only dependency `@mswjs/http-middleware` into the `devDependencies` section. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 7939f60) # Conflicts: # package.json # yarn.lock
@elasticmachine merge upstream |
@elasticmachine merge upstream |
kc13greiner
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
jeramysoucy
referenced
this pull request
Sep 18, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [Upgrade express 4.19.2→4.21.0 (#192862)](#192862) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T09:03:26Z","message":"Upgrade express 4.19.2→4.21.0 (#192862)\n\n## Summary\r\n\r\nUpgrades `express` from v4.19.2 to v4.21.0, and `@types/express` from\r\nv4.17.13 to v4.17.21. This PR also moves the dev-only dependency\r\n`@mswjs/http-middleware` into the `devDependencies` section.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7939f60f563af7c3f5402fcc70a7bb3578644e62","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open","v8.16.0"],"number":192862,"url":"https://github.com/elastic/kibana/pull/192862","mergeCommit":{"message":"Upgrade express 4.19.2→4.21.0 (#192862)\n\n## Summary\r\n\r\nUpgrades `express` from v4.19.2 to v4.21.0, and `@types/express` from\r\nv4.17.13 to v4.17.21. This PR also moves the dev-only dependency\r\n`@mswjs/http-middleware` into the `devDependencies` section.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7939f60f563af7c3f5402fcc70a7bb3578644e62"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192862","number":192862,"mergeCommit":{"message":"Upgrade express 4.19.2→4.21.0 (#192862)\n\n## Summary\r\n\r\nUpgrades `express` from v4.19.2 to v4.21.0, and `@types/express` from\r\nv4.17.13 to v4.17.21. This PR also moves the dev-only dependency\r\n`@mswjs/http-middleware` into the `devDependencies` section.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7939f60f563af7c3f5402fcc70a7bb3578644e62"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/193124","number":193124,"state":"MERGED","mergeCommit":{"sha":"ec719e0c2adbf707701892198743dd7b263a5b67","message":"[8.x] Upgrade express 4.19.2→4.21.0 (#192862) (#193124)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [Upgrade express 4.19.2→4.21.0\n(#192862)](https://github.com/elastic/kibana/pull/192862)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Jeramy\nSoucy\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-09-17T09:03:26Z\",\"message\":\"Upgrade\nexpress 4.19.2→4.21.0 (#192862)\\n\\n## Summary\\r\\n\\r\\nUpgrades `express`\nfrom v4.19.2 to v4.21.0, and `@types/express` from\\r\\nv4.17.13 to\nv4.17.21. This PR also moves the dev-only\ndependency\\r\\n`@mswjs/http-middleware` into the `devDependencies`\nsection.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: kibanamachine\n<[email protected]>\",\"sha\":\"7939f60f563af7c3f5402fcc70a7bb3578644e62\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Security\",\"release_note:skip\",\"v9.0.0\",\"backport:all-open\",\"v8.16.0\"],\"title\":\"Upgrade\nexpress\n4.19.2→4.21.0\",\"number\":192862,\"url\":\"https://github.com/elastic/kibana/pull/192862\",\"mergeCommit\":{\"message\":\"Upgrade\nexpress 4.19.2→4.21.0 (#192862)\\n\\n## Summary\\r\\n\\r\\nUpgrades `express`\nfrom v4.19.2 to v4.21.0, and `@types/express` from\\r\\nv4.17.13 to\nv4.17.21. This PR also moves the dev-only\ndependency\\r\\n`@mswjs/http-middleware` into the `devDependencies`\nsection.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: kibanamachine\n<[email protected]>\",\"sha\":\"7939f60f563af7c3f5402fcc70a7bb3578644e62\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/192862\",\"number\":192862,\"mergeCommit\":{\"message\":\"Upgrade\nexpress 4.19.2→4.21.0 (#192862)\\n\\n## Summary\\r\\n\\r\\nUpgrades `express`\nfrom v4.19.2 to v4.21.0, and `@types/express` from\\r\\nv4.17.13 to\nv4.17.21. This PR also moves the dev-only\ndependency\\r\\n`@mswjs/http-middleware` into the `devDependencies`\nsection.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: kibanamachine\n<[email protected]>\",\"sha\":\"7939f60f563af7c3f5402fcc70a7bb3578644e62\"}},{\"branch\":\"8.x\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v8.16.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Jeramy Soucy <[email protected]>"}},{"url":"https://github.com/elastic/kibana/pull/193130","number":193130,"branch":"7.17","state":"OPEN"}]}] BACKPORT-->
jeramysoucy
added a commit
that referenced
this pull request
Sep 18, 2024
## Summary This PR consolidates versions of `has-property-descriptors` in the yarn lock file. It's a follow-up to #193130, which auto-merged before fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to7.17
:Questions ?
Please refer to the Backport tool documentation