[ML][Fleet] Adds link to anomaly detection configurations from Integration > Assets tab#193105
Merged
alvarezmelissa87 merged 7 commits intoelastic:mainfrom Sep 19, 2024
Conversation
alvarezmelissa87
added
release_note:enhancement
:ml
Team:Fleet
3 tasks
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Sep 17, 2024
x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx
Outdated
Show resolved
Hide resolved
szabosteve
reviewed
Sep 18, 2024
| ), | ||
| 'ml-module': i18n.translate('xpack.fleet.epm.assetTitles.mlModules', { | ||
| defaultMessage: 'ML modules', | ||
| defaultMessage: 'Anomaly Detection configurations', |
Contributor
There was a problem hiding this comment.
Nit. I think it should be sentence case:
Suggested change
| defaultMessage: 'Anomaly Detection configurations', | |
| defaultMessage: 'Anomaly detection configurations', |
When we use anomaly detection as the name of a menu item in the nav, it's Anomaly Detection, otherwise sentence case is preferred.
szabosteve
reviewed
Sep 18, 2024
x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
This has been updated and is ready for a final look when you get a chance 🙏 cc @peteharverson, @szabosteve, @walterra |
peteharverson
approved these changes
Sep 19, 2024
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Latest changes LGTM
peteharverson
changed the title
Contributor
Author
|
@elasticmachine merge upstream |
walterra
approved these changes
Sep 19, 2024
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
LGTM, just added a question about schema. About stringMatch: Would be good to add some unit tests that work with the update but would fail with the previous version. In a follow we could also consolidate the duplicate code into a package.
Comment on lines
+104
to
+114
| const schema = useMemo( | ||
| () => ({ | ||
| strict: true, | ||
| fields: { | ||
| tags: { | ||
| type: 'string', | ||
| }, | ||
| }, | ||
| }), | ||
| [] | ||
| ); |
Contributor
There was a problem hiding this comment.
This looks like it's just initialized once without any options, could it be moved outside the component without the useMemo()?
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
Author
Added unit tests in 6434887 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
…ation > Assets tab (elastic#193105) ## Summary Related issue: elastic#182199 This PR adds a link to `ML > Anomaly Detection > Supplied Configurations` from `Integration > Assets tab` for 'ML Modules' assets. The naming of the asset is also updated in Fleet to be consistent with the ML UI. <img width="429" alt="Screenshot 2024-09-19 at 13 46 47" src="https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57"> <img width="717" alt="Screenshot 2024-09-19 at 13 47 52" src="https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 052187c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 19, 2024
…Integration > Assets tab (#193105) (#193485) # Backport This will backport the following commits from `main` to `8.x`: - [[ML][Fleet] Adds link to anomaly detection configurations from Integration > Assets tab (#193105)](#193105) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Melissa Alvarez","email":"melissa.alvarez@elastic.co"},"sourceCommit":{"committedDate":"2024-09-19T20:40:44Z","message":"[ML][Fleet] Adds link to anomaly detection configurations from Integration > Assets tab (#193105)\n\n## Summary\r\n\r\nRelated issue: #182199 PR adds a link to `ML > Anomaly Detection > Supplied\r\nConfigurations` from `Integration > Assets tab` for 'ML Modules' assets.\r\n\r\nThe naming of the asset is also updated in Fleet to be consistent with\r\nthe ML UI.\r\n\r\n<img width=\"429\" alt=\"Screenshot 2024-09-19 at 13 46 47\"\r\nsrc=\"https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57\">\r\n\r\n<img width=\"717\" alt=\"Screenshot 2024-09-19 at 13 47 52\"\r\nsrc=\"https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"052187ce180f0cbcb062486f36a562495f840bef","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ML][Fleet] Adds link to anomaly detection configurations from Integration > Assets tab","number":193105,"url":"https://github.com/elastic/kibana/pull/193105","mergeCommit":{"message":"[ML][Fleet] Adds link to anomaly detection configurations from Integration > Assets tab (#193105)\n\n## Summary\r\n\r\nRelated issue: #182199 PR adds a link to `ML > Anomaly Detection > Supplied\r\nConfigurations` from `Integration > Assets tab` for 'ML Modules' assets.\r\n\r\nThe naming of the asset is also updated in Fleet to be consistent with\r\nthe ML UI.\r\n\r\n<img width=\"429\" alt=\"Screenshot 2024-09-19 at 13 46 47\"\r\nsrc=\"https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57\">\r\n\r\n<img width=\"717\" alt=\"Screenshot 2024-09-19 at 13 47 52\"\r\nsrc=\"https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"052187ce180f0cbcb062486f36a562495f840bef"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193105","number":193105,"mergeCommit":{"message":"[ML][Fleet] Adds link to anomaly detection configurations from Integration > Assets tab (#193105)\n\n## Summary\r\n\r\nRelated issue: #182199 PR adds a link to `ML > Anomaly Detection > Supplied\r\nConfigurations` from `Integration > Assets tab` for 'ML Modules' assets.\r\n\r\nThe naming of the asset is also updated in Fleet to be consistent with\r\nthe ML UI.\r\n\r\n<img width=\"429\" alt=\"Screenshot 2024-09-19 at 13 46 47\"\r\nsrc=\"https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57\">\r\n\r\n<img width=\"717\" alt=\"Screenshot 2024-09-19 at 13 47 52\"\r\nsrc=\"https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"052187ce180f0cbcb062486f36a562495f840bef"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #182199
This PR adds a link to
ML > Anomaly Detection > Supplied ConfigurationsfromIntegration > Assets tabfor 'ML Modules' assets.The naming of the asset is also updated in Fleet to be consistent with the ML UI.
Checklist
Delete any items that are not applicable to this PR.