Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Defend Workflows] Fix bug when event filter value cannot be changed without using {backspace} (#192196) #192977

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[8.x] [Defend Workflows] Fix bug when event filter value cannot be changed without using {backspace} (#192196) #192977

merged 1 commit into from
Sep 16, 2024
+200 −34

Conversation

gergoabraham
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@gergoabraham
[Defend Workflows] Fix bug when event filter value cannot be changed …
2406642 
…without using {backspace} (elastic#192196)

## Summary

This PR does 2 things around editing the value field for an Event
Filter.

1. It fixes the issue when during editing an existing Event Filter you
cannot update the value without pressing {backspace}, by clearing
selection when user is typing: 5da28aa
Before:

![before](https://github.com/user-attachments/assets/7355c788-a9fd-4ea5-81b3-89ae41db2ee7)
➡️
After:

![after](https://github.com/user-attachments/assets/aa928fa4-6203-4fad-8f9b-4e586ac4d562)

2. Improves suggestions: before the change, suggestions were there
initially, but after they are narrowed down by typing, they won't be
displayed again after the user clears the input field. Therefore
f9d60cf sets the suggestion search
query unconditionally, helping with this issue.
Before:

![before](https://github.com/user-attachments/assets/87ccfba6-5b9d-4976-a5af-13c3d56db373)
➡️
After:

![after](https://github.com/user-attachments/assets/c21a909c-4b45-470e-9e77-9edc269f07f7)

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit b31d119)
@gergoabraham gergoabraham enabled auto-merge (squash) September 16, 2024 09:01
@gergoabraham gergoabraham mentioned this pull request Sep 16, 2024
Merged
1 task
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 16, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / EditableMarkdown Save button click calls onSaveContent and onChangeEditable when text area value changed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 143.3KB 143.3KB +10.0B
securitySolution 20.3MB 20.3MB +10.0B
total +20.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gergoabraham gergoabraham merged commit 0f26581 into elastic:8.x Sep 16, 2024
40 checks passed
@gergoabraham gergoabraham deleted the backport/8.x/pr-192196 branch September 16, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwarckonrad szwarckonrad szwarckonrad approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gergoabraham @kibana-ci @szwarckonrad