[SLOs] Try async creation of resources !!

x-pack/plugins/observability_solution/slo/public/hooks/use_create_rule.ts → x-pack/plugins/observability_solution/slo/public/hooks/use_create_burn_rate_rule.tsx

@@ -5,6 +5,7 @@
  * 2.0.
  */
 
+import React from 'react';
 import { useMutation } from '@tanstack/react-query';
 import { i18n } from '@kbn/i18n';
 import { BASE_ALERTING_API_PATH, RuleTypeParams } from '@kbn/alerting-plugin/common';
@@ -13,18 +14,23 @@ import type {
   CreateRuleRequestBody,
   CreateRuleResponse,
 } from '@kbn/alerting-plugin/common/routes/rule/apis/create';
+import { EuiFlexGroup, EuiFlexItem, EuiLoadingSpinner } from '@elastic/eui';
+import { toMountPoint } from '@kbn/react-kibana-mount';
 import { useKibana } from '../utils/kibana_react';
 
 export function useCreateRule<Params extends RuleTypeParams = never>() {
   const {
     http,
+    i18n: i18nStart,
     notifications: { toasts },
+    theme,
   } = useKibana().services;
 
-  const createRule = useMutation<
+  return useMutation<
     CreateRuleResponse<Params>,
     Error,
-    { rule: CreateRuleRequestBody<Params> }
+    { rule: CreateRuleRequestBody<Params> },
+    { loadingToastId?: string }
   >(
     ['createRule'],
     ({ rule }) => {
@@ -39,6 +45,24 @@ export function useCreateRule<Params extends RuleTypeParams = never>() {
       }
     },
     {
+      onMutate: async () => {
+        const loadingToast = toasts.addInfo({
+          title: toMountPoint(
+            <EuiFlexGroup justifyContent="center" alignItems="center">
+              <EuiFlexItem grow={false}>
+                {i18n.translate('xpack.slo.rules.createRule.loadingNotification.descriptionText', {
+                  defaultMessage: 'Creating burn rate rule ...',
+                })}
+              </EuiFlexItem>
+              <EuiFlexItem grow={false}>
+                <EuiLoadingSpinner size="s" />
+              </EuiFlexItem>
+            </EuiFlexGroup>,
+            { i18n: i18nStart, theme }
+          ),
+        });
+        return { loadingToastId: loadingToast.id };
+      },
       onError: (_err) => {
         toasts.addDanger(
           i18n.translate('xpack.slo.rules.createRule.errorNotification.descriptionText', {
@@ -54,8 +78,11 @@ export function useCreateRule<Params extends RuleTypeParams = never>() {
           })
         );
       },
+      onSettled: (_d, _err, _res, ctx) => {
+        if (ctx?.loadingToastId) {
+          toasts.remove(ctx?.loadingToastId);
+        }
+      },
     }
   );
-
-  return createRule;
 }

x-pack/plugins/observability_solution/slo/public/hooks/use_create_slo.tsx

@@ -55,7 +55,7 @@ export function useCreateSlo() {
               <RedirectAppLinks coreStart={services} data-test-subj="observabilityMainContainer">
                 <FormattedMessage
                   id="xpack.slo.slo.create.successNotification"
-                  defaultMessage="Successfully created {name}. {editSLO}"
+                  defaultMessage='Successfully created SLO: "{name}". {editSLO}'
                   values={{
                     name: slo.name,
                     editSLO: (

x-pack/plugins/observability_solution/slo/public/pages/slo_edit/components/slo_edit_form_footer.tsx

@@ -11,7 +11,7 @@ import type { GetSLOResponse } from '@kbn/slo-schema';
 import React, { useCallback, useMemo } from 'react';
 import { useFormContext } from 'react-hook-form';
 import { InPortal } from 'react-reverse-portal';
-import { useCreateRule } from '../../../hooks/use_create_rule';
+import { useCreateRule } from '../../../hooks/use_create_burn_rate_rule';
 import { useKibana } from '../../../utils/kibana_react';
 import { sloEditFormFooterPortal } from '../shared_flyout/slo_add_form_flyout';
 import { paths } from '../../../../common/locators/paths';
@@ -32,8 +32,6 @@ export interface Props {
   onSave?: () => void;
 }
 
-export const maxWidth = 775;
-
 export function SloEditFormFooter({ slo, onSave }: Props) {
   const {
     application: { navigateToUrl },
@@ -45,7 +43,7 @@ export function SloEditFormFooter({ slo, onSave }: Props) {
 
   const { mutateAsync: createSlo, isLoading: isCreateSloLoading } = useCreateSlo();
   const { mutateAsync: updateSlo, isLoading: isUpdateSloLoading } = useUpdateSlo();
-  const { mutateAsync: createBurnRateRule, isLoading: isCreateBurnRateRuleLoading } =
+  const { mutate: createBurnRateRule, isLoading: isCreateBurnRateRuleLoading } =
     useCreateRule<BurnRateRuleParams>();
 
   const navigate = useCallback(
@@ -70,7 +68,7 @@ export function SloEditFormFooter({ slo, onSave }: Props) {
     } else {
       const processedValues = transformCreateSLOFormToCreateSLOInput(values);
       const resp = await createSlo({ slo: processedValues });
-      await createBurnRateRule({
+      createBurnRateRule({
         rule: createBurnRateRuleRequestBody({ ...processedValues, id: resp.id }),
       });
       if (onSave) {

x-pack/plugins/observability_solution/slo/public/pages/slo_edit/slo_edit.test.tsx

@@ -23,7 +23,7 @@ import { useFetchApmSuggestions } from '../../hooks/use_fetch_apm_suggestions';
 import { useFetchIndices } from '../../hooks/use_fetch_indices';
 import { useFetchSloDetails } from '../../hooks/use_fetch_slo_details';
 import { usePermissions } from '../../hooks/use_permissions';
-import { useCreateRule } from '../../hooks/use_create_rule';
+import { useCreateRule } from '../../hooks/use_create_burn_rate_rule';
 import { useUpdateSlo } from '../../hooks/use_update_slo';
 import { useKibana } from '../../utils/kibana_react';
 import { kibanaStartMock } from '../../utils/kibana_react.mock';
@@ -45,7 +45,7 @@ jest.mock('../../hooks/use_create_slo');
 jest.mock('../../hooks/use_update_slo');
 jest.mock('../../hooks/use_fetch_apm_suggestions');
 jest.mock('../../hooks/use_permissions');
-jest.mock('../../hooks/use_create_rule');
+jest.mock('../../hooks/use_create_burn_rate_rule');
 
 const mockUseKibanaReturnValue = kibanaStartMock.startContract();
 

x-pack/plugins/observability_solution/slo/server/routes/slo/route.ts

@@ -29,6 +29,8 @@ import {
   updateSLOParamsSchema,
 } from '@kbn/slo-schema';
 import { getOverviewParamsSchema } from '@kbn/slo-schema/src/rest_specs/routes/get_overview';
+import { KibanaRequest } from '@kbn/core-http-server';
+import { RegisterRoutesDependencies } from '../register_routes';
 import { GetSLOsOverview } from '../../services/get_slos_overview';
 import type { IndicatorTypes } from '../../domain/models';
 import {
@@ -91,6 +93,11 @@ const assertPlatinumLicense = async (context: SloRequestHandlerContext) => {
   }
 };
 
+const getSpaceId = async (deps: RegisterRoutesDependencies, request: KibanaRequest) => {
+  const spaces = await deps.getSpacesStart();
+  return (await spaces?.spacesService?.getActiveSpace(request))?.id ?? 'default';
+};
+
 const createSLORoute = createSloServerRoute({
   endpoint: 'POST /api/observability/slos 2023-10-31',
   options: {
@@ -101,18 +108,18 @@ const createSLORoute = createSloServerRoute({
   handler: async ({ context, params, logger, dependencies, request }) => {
     await assertPlatinumLicense(context);
 
-    const spaces = await dependencies.getSpacesStart();
     const dataViews = await dependencies.getDataViewsStart();
-    const spaceId = (await spaces?.spacesService?.getActiveSpace(request))?.id ?? 'default';
-
     const core = await context.core;
     const scopedClusterClient = core.elasticsearch.client;
     const esClient = core.elasticsearch.client.asCurrentUser;
     const basePath = dependencies.pluginsSetup.core.http.basePath;
     const soClient = core.savedObjects.client;
     const repository = new KibanaSavedObjectsSLORepository(soClient, logger);
 
-    const dataViewsService = await dataViews.dataViewsServiceFactory(soClient, esClient);
+    const [spaceId, dataViewsService] = await Promise.all([
+      getSpaceId(dependencies, request),
+      dataViews.dataViewsServiceFactory(soClient, esClient),
+    ]);
     const transformManager = new DefaultTransformManager(
       transformGenerators,
       scopedClusterClient,
@@ -125,7 +132,6 @@ const createSLORoute = createSloServerRoute({
       scopedClusterClient,
       logger
     );
-
     const createSLO = new CreateSLO(
       esClient,
       scopedClusterClient,
@@ -137,9 +143,7 @@ const createSLORoute = createSloServerRoute({
       basePath
     );
 
-    const response = await createSLO.execute(params.body);
-
-    return response;
+    return await createSLO.execute(params.body);
   },
 });
 

x-pack/plugins/observability_solution/slo/server/services/create_slo.test.ts

@@ -65,7 +65,7 @@ describe('CreateSLO', () => {
 
       const response = await createSLO.execute(sloParams);
 
-      expect(mockRepository.save).toHaveBeenCalledWith(
+      expect(mockRepository.create).toHaveBeenCalledWith(
         expect.objectContaining({
           ...sloParams,
           id: 'unique-id',
@@ -80,17 +80,14 @@ describe('CreateSLO', () => {
           version: 2,
           createdAt: expect.any(Date),
           updatedAt: expect.any(Date),
-        }),
-        { throwOnConflict: true }
+        })
       );
 
       expect(mockTransformManager.install).toHaveBeenCalled();
-      expect(mockTransformManager.start).toHaveBeenCalled();
       expect(
         mockScopedClusterClient.asSecondaryAuthUser.ingest.putPipeline.mock.calls[0]
       ).toMatchSnapshot();
       expect(mockSummaryTransformManager.install).toHaveBeenCalled();
-      expect(mockSummaryTransformManager.start).toHaveBeenCalled();
       expect(mockEsClient.index.mock.calls[0]).toMatchSnapshot();
 
       expect(response).toEqual(expect.objectContaining({ id: 'unique-id' }));
@@ -108,7 +105,7 @@ describe('CreateSLO', () => {
 
       await createSLO.execute(sloParams);
 
-      expect(mockRepository.save).toHaveBeenCalledWith(
+      expect(mockRepository.create).toHaveBeenCalledWith(
         expect.objectContaining({
           ...sloParams,
           id: expect.any(String),
@@ -122,8 +119,7 @@ describe('CreateSLO', () => {
           enabled: true,
           createdAt: expect.any(Date),
           updatedAt: expect.any(Date),
-        }),
-        { throwOnConflict: true }
+        })
       );
     });
 
@@ -141,7 +137,7 @@ describe('CreateSLO', () => {
 
       await createSLO.execute(sloParams);
 
-      expect(mockRepository.save).toHaveBeenCalledWith(
+      expect(mockRepository.create).toHaveBeenCalledWith(
         expect.objectContaining({
           ...sloParams,
           id: expect.any(String),
@@ -155,8 +151,7 @@ describe('CreateSLO', () => {
           enabled: true,
           createdAt: expect.any(Date),
           updatedAt: expect.any(Date),
-        }),
-        { throwOnConflict: true }
+        })
       );
     });
   });
@@ -173,16 +168,16 @@ describe('CreateSLO', () => {
       expect(mockRepository.deleteById).toHaveBeenCalled();
       expect(
         mockScopedClusterClient.asSecondaryAuthUser.ingest.deletePipeline
-      ).toHaveBeenCalledTimes(1);
+      ).toHaveBeenCalledTimes(2);
 
-      expect(mockSummaryTransformManager.stop).not.toHaveBeenCalled();
-      expect(mockSummaryTransformManager.uninstall).not.toHaveBeenCalled();
-      expect(mockTransformManager.stop).not.toHaveBeenCalled();
-      expect(mockTransformManager.uninstall).not.toHaveBeenCalled();
+      expect(mockSummaryTransformManager.stop).toHaveBeenCalledTimes(0);
+      expect(mockSummaryTransformManager.uninstall).toHaveBeenCalledTimes(1);
+      expect(mockTransformManager.stop).toHaveBeenCalledTimes(0);
+      expect(mockTransformManager.uninstall).toHaveBeenCalledTimes(1);
     });
 
-    it('rollbacks completed operations when summary transform start fails', async () => {
-      mockSummaryTransformManager.start.mockRejectedValue(
+    it('rollbacks completed operations when summary transform install fails', async () => {
+      mockSummaryTransformManager.install.mockRejectedValue(
         new Error('Summary transform install error')
       );
       const sloParams = createSLOParams({ indicator: createAPMTransactionErrorRateIndicator() });
@@ -192,7 +187,7 @@ describe('CreateSLO', () => {
       );
 
       expect(mockRepository.deleteById).toHaveBeenCalled();
-      expect(mockTransformManager.stop).toHaveBeenCalled();
+      expect(mockTransformManager.stop).not.toHaveBeenCalled();
       expect(mockTransformManager.uninstall).toHaveBeenCalled();
       expect(
         mockScopedClusterClient.asSecondaryAuthUser.ingest.deletePipeline
@@ -211,12 +206,12 @@ describe('CreateSLO', () => {
       );
 
       expect(mockRepository.deleteById).toHaveBeenCalled();
-      expect(mockTransformManager.stop).toHaveBeenCalled();
+      expect(mockTransformManager.stop).not.toHaveBeenCalled();
       expect(mockTransformManager.uninstall).toHaveBeenCalled();
       expect(
         mockScopedClusterClient.asSecondaryAuthUser.ingest.deletePipeline
       ).toHaveBeenCalledTimes(2);
-      expect(mockSummaryTransformManager.stop).toHaveBeenCalled();
+      expect(mockSummaryTransformManager.stop).not.toHaveBeenCalled();
       expect(mockSummaryTransformManager.uninstall).toHaveBeenCalled();
     });
   });