[Security GenAI] Re-add telemetry for isEnabledKnowledgeBase#192785
Merged
stephmilovic merged 4 commits intoelastic:mainfrom Sep 13, 2024
Merged
[Security GenAI] Re-add telemetry for isEnabledKnowledgeBase#192785stephmilovic merged 4 commits intoelastic:mainfrom
isEnabledKnowledgeBase#192785stephmilovic merged 4 commits intoelastic:mainfrom
Conversation
stephmilovic
added
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
spong
reviewed
Sep 12, 2024
spong
reviewed
Sep 12, 2024
spong
approved these changes
Sep 12, 2024
Member
spong
left a comment
spong
left a comment
There was a problem hiding this comment.
Code changes LGTM! Left a couple notes about a slight difference between client/server checks and a conflict we'll see when backporting to 8.15.2, but overall everything looks 👍 to me.
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2024
…ic#192785) (cherry picked from commit cabaf7a)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Sep 13, 2024
…ic#192785) (cherry picked from commit cabaf7a) # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/chat_send/use_chat_send.tsx # x-pack/plugins/elastic_assistant/server/routes/helpers.ts # x-pack/plugins/elastic_assistant/server/routes/post_actions_connector_execute.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2024
…ase` (#192785) (#192937) # Backport This will backport the following commits from `main` to `8.x`: - [[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)](#192785) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-09-13T23:17:08Z","message":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","v8.15.2"],"title":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase`","number":192785,"url":"https://github.com/elastic/kibana/pull/192785","mergeCommit":{"message":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192785","number":192785,"mergeCommit":{"message":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
stephmilovic
added a commit
that referenced
this pull request
Sep 15, 2024
…#192785) (#192938) # Backport This will backport the following commits from `main` to `8.15`: - [[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)](#192785) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-09-13T23:17:08Z","message":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","v8.15.2"],"number":192785,"url":"https://github.com/elastic/kibana/pull/192785","mergeCommit":{"message":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192785","number":192785,"mergeCommit":{"message":"[Security GenAI] Re-add telemetry for `isEnabledKnowledgeBase` (#192785)","sha":"cabaf7a0774cda8775c059c36b7db7679ca19d8a"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/192937","number":192937,"state":"OPEN"},{"branch":"8.15","label":"v8.15.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isEnabledKnowledgeBasewas removed from the browser side eventAssistant Message Sentand the server side eventsinvoke_assistant_success/invoke_assistant_error. When we originally merged the KB work, we were under the impression KB would be installed by default. At the last minute in 8.15 release cycle, it was decided that enabling it automatically can have cost concerns, so we opted for the button. We forgot to go back and re-add the isEnabledKnowledgeBase property. This PR addresses that.