Skip to content

[Chore] Remove third-party testing internals from test snapshots #192747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rylnd merged 2 commits into from
Sep 13, 2024
Merged

[Chore] Remove third-party testing internals from test snapshots #192747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1422369
Remove third-party testing internals from test snapshots
rylnd Sep 12, 2024
f181993
Merge branch 'main' into remove_internals_from_snapshots
rylnd Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
743 changes: 154 additions & 589 deletions ...s/kbn-securitysolution-autocomplete/src/field/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions packages/kbn-securitysolution-autocomplete/src/field/__tests__/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('FieldComponent', () => {
selectedField={getField('machine.os.raw')}
/>
);
expect(wrapper).toMatchSnapshot();
expect(wrapper.container).toMatchSnapshot();
const comboBox = wrapper.getByTestId('fieldAutocompleteComboBox');
const input = within(comboBox).getByRole('combobox');
expect(input).toHaveAttribute('value', 'machine.os.raw');
Expand All @@ -52,7 +52,7 @@ describe('FieldComponent', () => {
selectedField={getField('machine.os.raw')}
/>
);
expect(wrapper).toMatchSnapshot();
expect(wrapper.container).toMatchSnapshot();
expect(wrapper.getByTestId('fieldAutocompleteComboBox').querySelector('input')).toBeDisabled();
});
it('should render the loading spinner if isLoading is true when clicked', () => {
Expand All @@ -72,7 +72,7 @@ describe('FieldComponent', () => {
/>
);
const fieldAutocompleteComboBox = wrapper.getByTestId('fieldAutocompleteComboBox');
expect(wrapper).toMatchSnapshot();
expect(wrapper.container).toMatchSnapshot();
fireEvent.click(fieldAutocompleteComboBox);
expect(wrapper.getByRole('progressbar')).toBeInTheDocument();
});
Expand All @@ -92,7 +92,7 @@ describe('FieldComponent', () => {
selectedField={getField('machine.os.raw')}
/>
);
expect(wrapper).toMatchSnapshot();
expect(wrapper.container).toMatchSnapshot();
expect(wrapper.getByTestId('comboBoxClearButton')).toBeInTheDocument();
});
it('should change the selected value', async () => {
Expand Down
Loading