Skip to content

[Response Ops][Alerting] Only load maintenance windows when there are alerts during rule execution and caching loaded maintenance windows #192573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ymao1 merged 22 commits into from
Sep 26, 2024
Merged

[Response Ops][Alerting] Only load maintenance windows when there are alerts during rule execution and caching loaded maintenance windows #192573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a544490
Only loading maintenance windows if there are new alerts to persist
ymao1 Sep 12, 2024
6f71723
Fixing types
ymao1 Sep 12, 2024
71b7538
Need to load when there are any alerts not just new
ymao1 Sep 13, 2024
e097e99
Merging in main
ymao1 Sep 13, 2024
8d82191
Need to load when there are any alerts not just new
ymao1 Sep 13, 2024
3ef5f22
Merging in main
ymao1 Sep 16, 2024
9a5f463
wip
ymao1 Sep 16, 2024
9293e37
Caching maintenance windows
ymao1 Sep 16, 2024
c5af98f
Fixing tests
ymao1 Sep 16, 2024
cbb7c82
Fixing types
ymao1 Sep 16, 2024
18f8e10
Merge branch 'main' of github.com:elastic/kibana into alerting/load-m…
ymao1 Sep 16, 2024
1b98138
Taking cache interval into account when querying for maintenance windows
ymao1 Sep 18, 2024
2044596
Merge branch 'main' of github.com:elastic/kibana into alerting/load-m…
ymao1 Sep 18, 2024
57fd492
Merge branch 'main' into alerting/load-maintenance-windows-later
elasticmachine Sep 19, 2024
3dd0eac
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine Sep 19, 2024
fc94013
Merge branch 'main' into alerting/load-maintenance-windows-later
elasticmachine Sep 19, 2024
46e48cf
Fixing test
ymao1 Sep 20, 2024
99556c2
Merge branch 'main' of github.com:elastic/kibana into alerting/load-m…
ymao1 Sep 20, 2024
5e3d400
Merge branch 'main' into alerting/load-maintenance-windows-later
elasticmachine Sep 23, 2024
120df74
Merge branch 'main' of github.com:elastic/kibana into alerting/load-m…
ymao1 Sep 25, 2024
883d909
PR feedback
ymao1 Sep 25, 2024
3e43f91
Merge branch 'main' into alerting/load-maintenance-windows-later
elasticmachine Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions x-pack/plugins/alerting/server/alert/create_alert_factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,6 @@ export function createAlertFactory<
autoRecoverAlerts,
// flappingSettings.enabled is false, as we only want to use this function to get the recovered alerts
flappingSettings: DISABLE_FLAPPING_SETTINGS,
// no maintenance window IDs are passed as we only want to use this function to get recovered alerts
maintenanceWindowIds: [],
});
return Object.keys(currentRecoveredAlerts ?? {}).map(
(alertId: string) => currentRecoveredAlerts[alertId]
Expand Down
Loading