[APM][Otel] Add Otel client based on PoC data#192293
Merged
jennypavlova merged 24 commits intoelastic:mainfrom Oct 14, 2024
Merged
Conversation
jennypavlova
added
the
Team:obs-ux-infra_services - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
MiriamAparicio
force-pushed
the
192115-apmotel-add-synthtrace-scenarios-to-test-with-otel-data
branch
from
6013cb3 to
5c95114
Compare
…est-with-otel-data
…el-data' of https://github.com/jennypavlova/kibana into 192115-apmotel-add-synthtrace-scenarios-to-test-with-otel-data
…est-with-otel-data
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
changed the title
jennypavlova
added
release_note:skip
botelastic
bot
added
the
ci:project-deploy-observability
Contributor
|
@gregkalapos can you review this PR and check that the fields and everything looks good, @jennypavlova and I used the Otel documents on the POC as a source of truth but just to double-check 🙏 |
jennypavlova
force-pushed
the
192115-apmotel-add-synthtrace-scenarios-to-test-with-otel-data
branch
from
eeaa2c1 to
832abf1
Compare
…est-with-otel-data
MiriamAparicio
approved these changes
Oct 9, 2024
Contributor
MiriamAparicio
left a comment
MiriamAparicio
left a comment
There was a problem hiding this comment.
LGTM 🌟
Thanks for the team work 💪
gregkalapos
reviewed
Oct 9, 2024
Contributor
gregkalapos
left a comment
gregkalapos
left a comment
There was a problem hiding this comment.
Some findings below regarding fields.
gregkalapos
approved these changes
Oct 14, 2024
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
History
|
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
rmyz
pushed a commit
to rmyz/kibana
that referenced
this pull request
Feb 18, 2025
Closes [elastic#192115](elastic#192115) Closes [elastic#192465](elastic#192465) ## Summary This PR adds synthrace client for Otel native data and a simple scenario. This is the first step of adding it and in the future it will include more metrics and use cases. >[!NOTE] > To run ES the command needs "xpack.otel_data.registry.enabled=true" flag > `yarn es snapshot --license trial --E "xpack.otel_data.registry.enabled=true"` ## Next steps - We currently have only `service_destination` in the metrics indices we can include the other types in the future - After we have all the UI changes we can add more scenarios (also using the opentelemetry demo data and not only the e2e PoC example) ## Testing - Run ES: ```bash yarn es snapshot --license trial --E "xpack.otel_data.registry.enabled=true" ``` - Run Kibana: ```bash yarn start ``` >[!WARNING] If the e2e PoC is used the first 2 steps should be skipped - Run syntrace: ```bash node scripts/synthtrace otel_simple_trace.ts --clean ``` - Check indices in DevTools for the generated data: ```bash GET *metrics-generic.otel*/_search GET *traces-generic.otel*/_search GET *logs-generic.otel*/_search ``` - Check in the APM UI (all the tabs) >[!WARNING] Currently the UI changes done in APM are not merged so some errors are expected) https://github.com/user-attachments/assets/92f63610-82da-40f3-89bb-00be83c55377 --------- Co-authored-by: miriam.aparicio <miriam.aparicio@gmail.com> (cherry picked from commit 5067f15) # Conflicts: # packages/kbn-apm-synthtrace-client/index.ts # packages/kbn-apm-synthtrace/src/cli/scenario.ts # packages/kbn-apm-synthtrace/src/cli/utils/bootstrap.ts # packages/kbn-apm-synthtrace/src/cli/utils/start_live_data_upload.ts # packages/kbn-apm-synthtrace/src/cli/utils/synthtrace_worker.ts
rmyz
added a commit
that referenced
this pull request
Feb 18, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[APM][Otel] Add Otel client based on PoC data (#192293)](#192293) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-14T12:33:22Z","message":"[APM][Otel] Add Otel client based on PoC data (#192293)\n\nCloses [#192115](https://github.com/elastic/kibana/issues/192115)\r\nCloses [#192465](https://github.com/elastic/kibana/issues/192465)\r\n\r\n\r\n## Summary\r\n\r\nThis PR adds synthrace client for Otel native data and a simple\r\nscenario. This is the first step of adding it and in the future it will\r\ninclude more metrics and use cases.\r\n\r\n>[!NOTE]\r\n> To run ES the command needs \"xpack.otel_data.registry.enabled=true\"\r\nflag\r\n> `yarn es snapshot --license trial --E\r\n\"xpack.otel_data.registry.enabled=true\"`\r\n\r\n## Next steps\r\n- We currently have only `service_destination` in the metrics indices we\r\ncan include the other types in the future\r\n- After we have all the UI changes we can add more scenarios (also using\r\nthe opentelemetry demo data and not only the e2e PoC example)\r\n\r\n## Testing\r\n- Run ES: \r\n```bash \r\nyarn es snapshot --license trial --E \"xpack.otel_data.registry.enabled=true\"\r\n```\r\n- Run Kibana:\r\n```bash \r\nyarn start\r\n```\r\n\r\n>[!WARNING]\r\nIf the e2e PoC is used the first 2 steps should be skipped\r\n\r\n- Run syntrace: \r\n```bash\r\nnode scripts/synthtrace otel_simple_trace.ts --clean\r\n```\r\n- Check indices in DevTools for the generated data: \r\n```bash \r\nGET *metrics-generic.otel*/_search\r\n\r\nGET *traces-generic.otel*/_search\r\n\r\nGET *logs-generic.otel*/_search\r\n```\r\n- Check in the APM UI (all the tabs) \r\n>[!WARNING]\r\nCurrently the UI changes done in APM are not merged so some errors are\r\nexpected)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/92f63610-82da-40f3-89bb-00be83c55377\r\n\r\n---------\r\n\r\nCo-authored-by: miriam.aparicio <miriam.aparicio@gmail.com>","sha":"5067f1554cb5fc7f23442d5f9ab5d255e26a3b37","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","OpenTelemetry","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM][Otel] Add Otel client based on PoC data","number":192293,"url":"https://github.com/elastic/kibana/pull/192293","mergeCommit":{"message":"[APM][Otel] Add Otel client based on PoC data (#192293)\n\nCloses [#192115](https://github.com/elastic/kibana/issues/192115)\r\nCloses [#192465](https://github.com/elastic/kibana/issues/192465)\r\n\r\n\r\n## Summary\r\n\r\nThis PR adds synthrace client for Otel native data and a simple\r\nscenario. This is the first step of adding it and in the future it will\r\ninclude more metrics and use cases.\r\n\r\n>[!NOTE]\r\n> To run ES the command needs \"xpack.otel_data.registry.enabled=true\"\r\nflag\r\n> `yarn es snapshot --license trial --E\r\n\"xpack.otel_data.registry.enabled=true\"`\r\n\r\n## Next steps\r\n- We currently have only `service_destination` in the metrics indices we\r\ncan include the other types in the future\r\n- After we have all the UI changes we can add more scenarios (also using\r\nthe opentelemetry demo data and not only the e2e PoC example)\r\n\r\n## Testing\r\n- Run ES: \r\n```bash \r\nyarn es snapshot --license trial --E \"xpack.otel_data.registry.enabled=true\"\r\n```\r\n- Run Kibana:\r\n```bash \r\nyarn start\r\n```\r\n\r\n>[!WARNING]\r\nIf the e2e PoC is used the first 2 steps should be skipped\r\n\r\n- Run syntrace: \r\n```bash\r\nnode scripts/synthtrace otel_simple_trace.ts --clean\r\n```\r\n- Check indices in DevTools for the generated data: \r\n```bash \r\nGET *metrics-generic.otel*/_search\r\n\r\nGET *traces-generic.otel*/_search\r\n\r\nGET *logs-generic.otel*/_search\r\n```\r\n- Check in the APM UI (all the tabs) \r\n>[!WARNING]\r\nCurrently the UI changes done in APM are not merged so some errors are\r\nexpected)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/92f63610-82da-40f3-89bb-00be83c55377\r\n\r\n---------\r\n\r\nCo-authored-by: miriam.aparicio <miriam.aparicio@gmail.com>","sha":"5067f1554cb5fc7f23442d5f9ab5d255e26a3b37"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192293","number":192293,"mergeCommit":{"message":"[APM][Otel] Add Otel client based on PoC data (#192293)\n\nCloses [#192115](https://github.com/elastic/kibana/issues/192115)\r\nCloses [#192465](https://github.com/elastic/kibana/issues/192465)\r\n\r\n\r\n## Summary\r\n\r\nThis PR adds synthrace client for Otel native data and a simple\r\nscenario. This is the first step of adding it and in the future it will\r\ninclude more metrics and use cases.\r\n\r\n>[!NOTE]\r\n> To run ES the command needs \"xpack.otel_data.registry.enabled=true\"\r\nflag\r\n> `yarn es snapshot --license trial --E\r\n\"xpack.otel_data.registry.enabled=true\"`\r\n\r\n## Next steps\r\n- We currently have only `service_destination` in the metrics indices we\r\ncan include the other types in the future\r\n- After we have all the UI changes we can add more scenarios (also using\r\nthe opentelemetry demo data and not only the e2e PoC example)\r\n\r\n## Testing\r\n- Run ES: \r\n```bash \r\nyarn es snapshot --license trial --E \"xpack.otel_data.registry.enabled=true\"\r\n```\r\n- Run Kibana:\r\n```bash \r\nyarn start\r\n```\r\n\r\n>[!WARNING]\r\nIf the e2e PoC is used the first 2 steps should be skipped\r\n\r\n- Run syntrace: \r\n```bash\r\nnode scripts/synthtrace otel_simple_trace.ts --clean\r\n```\r\n- Check indices in DevTools for the generated data: \r\n```bash \r\nGET *metrics-generic.otel*/_search\r\n\r\nGET *traces-generic.otel*/_search\r\n\r\nGET *logs-generic.otel*/_search\r\n```\r\n- Check in the APM UI (all the tabs) \r\n>[!WARNING]\r\nCurrently the UI changes done in APM are not merged so some errors are\r\nexpected)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/92f63610-82da-40f3-89bb-00be83c55377\r\n\r\n---------\r\n\r\nCo-authored-by: miriam.aparicio <miriam.aparicio@gmail.com>","sha":"5067f1554cb5fc7f23442d5f9ab5d255e26a3b37"}}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192115
Closes #192465
Summary
This PR adds synthrace client for Otel native data and a simple scenario. This is the first step of adding it and in the future it will include more metrics and use cases.
Note
To run ES the command needs "xpack.otel_data.registry.enabled=true" flag
yarn es snapshot --license trial --E "xpack.otel_data.registry.enabled=true"Next steps
service_destinationin the metrics indices we can include the other types in the futureTesting
yarn es snapshot --license trial --E "xpack.otel_data.registry.enabled=true"Warning
If the e2e PoC is used the first 2 steps should be skipped
Warning
Currently the UI changes done in APM are not merged so some errors are expected)
Screen.Recording.2024-10-07.at.20.52.34.mov