[Dashboard] Fix breadcrumb update icon does not working when clicked #192240
Conversation
|
💚 CLA has been signed |
viajes7
force-pushed
the
fix/dashboard-nav-update
branch
from
3f1d7c4
to
b223701
Compare
Heenawter
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
buildkite test this |
|
@elasticmachine run buildkite/docs-build-pr |
| {dashboardTitle} | ||
| <EuiIcon | ||
| size="s" | ||
| type="pencil" | ||
| className="dshTitleBreadcrumbs__updateIcon" | ||
| onClick={() => dashboard.showSettings()} | ||
| /> |
There was a problem hiding this comment.
@cqliu1 @andreadelrio How do we feel about this change? The last breadcrumb is enforced to be unclickable, and so the onClick is literally being stripped out when building the top nav (see #166785). This seems like a decent workaround to me (just making the icon clickable) but I'm interested in ya'lls thoughts 🤔
There was a problem hiding this comment.
I'm fine with having just the pencil icon be clickable. That's how I've seen other apps handle it
There was a problem hiding this comment.
Sounds good to me as well!
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
|
Hi @Heenawter, I noticed that a member of the elastic/kibana-design team is also needed to review the code. |
viajes7
force-pushed
the
fix/dashboard-nav-update
branch
from
c39492b
to
d514516
Compare
viajes7
force-pushed
the
fix/dashboard-nav-update
branch
from
d514516
to
7670844
Compare
|
@elasticmachine merge upstream |
|
@Heenawter Hi, The pipeline seems to be stuck, do you have any suggestions? |
|
buildkite test this |
|
@elasticmachine run buildkite/docs-build-pr |
|
buildkite test this |
|
@elasticmachine run buildkite/docs-build-pr |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Fixes #186132
In the
header_breadcrumbs.test.tsx, forces the last breadcrumb inactivity. SoonClickdid not take effect finally.So, I'm considering putting
onClickon the update icon.PS: This is my first time to contribute code to kibana. If there is anything that needs to be modified, please give me some advice and I will try my best.