Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rca): create and edit investigation form in flyout #192208

Merged
merged 11 commits into from
Sep 10, 2024

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Sep 5, 2024

resolves #192176
resolves #192105

Summary

This PR introduces a form used for editing and creating an investigation. Currently, the only available fields are the title and the status.

I've also removed the ESQL datatable in this PR.

Testing

Go to the investigation page, use the Create button to create a new investigation, then edit it. Add some esql items and notes.

rca.-.create.and.edit.flow.mov

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme
Copy link
Contributor Author

kdelemme commented Sep 5, 2024

/ci

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0 labels Sep 5, 2024
@kdelemme kdelemme marked this pull request as ready for review September 5, 2024 17:57
@kdelemme kdelemme requested review from a team as code owners September 5, 2024 17:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 5, 2024
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme enabled auto-merge (squash) September 9, 2024 15:49
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 9, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 49e31ab
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192208-49e31ab94b97

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
investigateApp 523 530 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
investigateApp 346.3KB 376.4KB +30.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
investigateApp 13.0KB 12.8KB -142.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kdelemme kdelemme merged commit 6ef9f6c into elastic:main Sep 10, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
7 participants