[APM UI] Fix Latency distribution chart breaks due to transaction durations of value 0 #191994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
added
release_note:fix
Team:obs-ux-infra_services
rmyz
force-pushed
the
184256-apm-ui-latency-distribution-chart-breaks-at-0
branch
from
597ddc3
to
8180339
Compare
crespocarlos
reviewed
Sep 4, 2024
...lity_solution/apm/server/routes/correlations/queries/fetch_duration_histogram_range_steps.ts
Outdated
Show resolved
Hide resolved
jennypavlova
added
v8.15.0
v8.14.3
backport:version
rmyz
force-pushed
the
184256-apm-ui-latency-distribution-chart-breaks-at-0
branch
from
dc527be
to
f9b3a90
Compare
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
|
/ci |
kpatticha
reviewed
Sep 4, 2024
...lity_solution/apm/server/routes/correlations/queries/fetch_duration_histogram_range_steps.ts
Outdated
Show resolved
Hide resolved
rmyz
force-pushed
the
184256-apm-ui-latency-distribution-chart-breaks-at-0
branch
2 times, most recently
from
20c073d
to
a071a1b
Compare
rmyz
force-pushed
the
184256-apm-ui-latency-distribution-chart-breaks-at-0
branch
from
a071a1b
to
a62c25d
Compare
kpatticha
approved these changes
Sep 5, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
rmyz
deleted the
184256-apm-ui-latency-distribution-chart-breaks-at-0
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 5, 2024
…ations of value 0 (elastic#191994) ## Summary Fixes: elastic#184256 This PR fixes the APM latency distribution chart not being able to render when we had any duration value as 0, to fix it, we now check if it's 0 and override it with 1. |Before|After| |-|-| ||| ## Test steps 1. Open the following file `x-pack/plugins/observability_solution/apm/server/routes/correlations/queries/fetch_duration_histogram_range_steps.ts` 2. Modify L61 and L118 changing the initial two values passed to `getHistogramRangeSteps` to 0. Like `getHistogramRangeSteps(0, 0, steps)`. It doesn't matter the order, if one of the params is at 0 it won't render anything. 3. Revert the change and check if the chart is being rendered. (cherry picked from commit 917473f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 5, 2024
…ion durations of value 0 (#191994) (#192165) # Backport This will backport the following commits from `main` to `8.15`: - [[APM UI] Fix Latency distribution chart breaks due to transaction durations of value 0 (#191994)](#191994) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-05T10:35:29Z","message":"[APM UI] Fix Latency distribution chart breaks due to transaction durations of value 0 (#191994)\n\n## Summary\r\nFixes: #184256 PR fixes the APM latency distribution chart not being able to\r\nrender when we had any duration value as 0, to fix it, we now check if\r\nit's 0 and override it with 1.\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||\r\n\r\n## Test steps\r\n1. Open the following file\r\n`x-pack/plugins/observability_solution/apm/server/routes/correlations/queries/fetch_duration_histogram_range_steps.ts`\r\n2. Modify L61 and L118 changing the initial two values passed to\r\n`getHistogramRangeSteps` to 0.\r\nLike `getHistogramRangeSteps(0, 0, steps)`.\r\nIt doesn't matter the order, if one of the params is at 0 it won't\r\nrender anything.\r\n3. Revert the change and check if the chart is being rendered.","sha":"917473f8321fd56b90f18e5a88d643d5abb7eb29","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm:charts","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.15.0","v8.16.0","backport:version"],"title":"[APM UI] Fix Latency distribution chart breaks due to transaction durations of value 0","number":191994,"url":"#191994 UI] Fix Latency distribution chart breaks due to transaction durations of value 0 (#191994)\n\n## Summary\r\nFixes: #184256 PR fixes the APM latency distribution chart not being able to\r\nrender when we had any duration value as 0, to fix it, we now check if\r\nit's 0 and override it with 1.\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||\r\n\r\n## Test steps\r\n1. Open the following file\r\n`x-pack/plugins/observability_solution/apm/server/routes/correlations/queries/fetch_duration_histogram_range_steps.ts`\r\n2. Modify L61 and L118 changing the initial two values passed to\r\n`getHistogramRangeSteps` to 0.\r\nLike `getHistogramRangeSteps(0, 0, steps)`.\r\nIt doesn't matter the order, if one of the params is at 0 it won't\r\nrender anything.\r\n3. Revert the change and check if the chart is being rendered.","sha":"917473f8321fd56b90f18e5a88d643d5abb7eb29"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"#191994 UI] Fix Latency distribution chart breaks due to transaction durations of value 0 (#191994)\n\n## Summary\r\nFixes: #184256 PR fixes the APM latency distribution chart not being able to\r\nrender when we had any duration value as 0, to fix it, we now check if\r\nit's 0 and override it with 1.\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||\r\n\r\n## Test steps\r\n1. Open the following file\r\n`x-pack/plugins/observability_solution/apm/server/routes/correlations/queries/fetch_duration_histogram_range_steps.ts`\r\n2. Modify L61 and L118 changing the initial two values passed to\r\n`getHistogramRangeSteps` to 0.\r\nLike `getHistogramRangeSteps(0, 0, steps)`.\r\nIt doesn't matter the order, if one of the params is at 0 it won't\r\nrender anything.\r\n3. Revert the change and check if the chart is being rendered.","sha":"917473f8321fd56b90f18e5a88d643d5abb7eb29"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #184256
This PR fixes the APM latency distribution chart not being able to render when we had any duration value as 0, to fix it, we now check if it's 0 and override it with 1.
Test steps
x-pack/plugins/observability_solution/apm/server/routes/correlations/queries/fetch_duration_histogram_range_steps.tsgetHistogramRangeStepsto 0.Like
getHistogramRangeSteps(0, 0, steps).It doesn't matter the order, if one of the params is at 0 it won't render anything.