[Beats Management] APIs: Get beat configuration#19195
Closed
ycombinator wants to merge 16 commits intoelastic:feature/x-pack/management/beatsfrom
Closed
[Beats Management] APIs: Get beat configuration#19195ycombinator wants to merge 16 commits intoelastic:feature/x-pack/management/beatsfrom
ycombinator wants to merge 16 commits intoelastic:feature/x-pack/management/beatsfrom
Conversation
ycombinator
force-pushed
the
x-pack/management/beats/apis/get-beat-configuration
branch
from
acb1aaf to
15b78f1
Compare
ycombinator
force-pushed
the
x-pack/management/beats/apis/get-beat-configuration
branch
2 times, most recently
from
353d590 to
cdbff83
Compare
ycombinator
force-pushed
the
feature/x-pack/management/beats
branch
from
01d9044 to
2c86794
Compare
ycombinator
force-pushed
the
x-pack/management/beats/apis/get-beat-configuration
branch
from
cdbff83 to
f8c1278
Compare
ycombinator
commented
May 25, 2018
Contributor
Author
There was a problem hiding this comment.
ycombinator
force-pushed
the
x-pack/management/beats/apis/get-beat-configuration
branch
from
5536241 to
6ad5aef
Compare
ycombinator
force-pushed
the
feature/x-pack/management/beats
branch
from
f4ab093 to
8d1a76c
Compare
* WIP checkin * Register API routes * Fixing typo in index name * Adding TODOs * Removing commented out license checking code that isn't yet implemented * Remove unnecessary async/await * Don't return until indices have been refreshed * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Adding TODO * Fixing variable name * Using a single index * Adding expiration date field * Adding test for expiration date field * Ignore non-existent index * Fixing logic in test * Creating constant for default enrollment tokens TTL value * Updating test
ycombinator
force-pushed
the
x-pack/management/beats/apis/get-beat-configuration
branch
from
6ad5aef to
8227550
Compare
Contributor
Author
|
@mattapperson This is a WIP PR that builds on top of what's already in the Once #20039 is merged this PR will also need to be ported over to TS + infra arch for consistency. Longer-term, the stub implemented in this PR will need to be replaced with actual functional code to build/retrieve the central config for the beat. |
Contributor
|
replaced with #20603 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one in a series of several PRs that will go towards resolving #18858.
This PR implements an HTTP API to retrieve a Beat's centrally-managed configuration. Beats agents are expected to call this API periodically.
Usage
Testing this PR
DELETE _template/beats-templateandDELETE .management-beats.BEAT_UUIDin the request URL is notfoo(that's a special ID being used by the integration tests). Eventually, once the APIs to create tags and associate them with beats are implemented, the hardcoded response can be removed and the PR can be put into proper review.