[DRAFT] Resolving color calculations testing branch#191801
Closed
mgadewoll wants to merge 26 commits intoelastic:mainfrom
Closed
[DRAFT] Resolving color calculations testing branch#191801mgadewoll wants to merge 26 commits intoelastic:mainfrom
mgadewoll wants to merge 26 commits intoelastic:mainfrom
Conversation
- caused by additional Emotion wrapper that matches the same selector
…ration - default props are no longer read/rendered by enzyme's snapshotter
…to `useGeneratedHtmlId` - requires updating mocks
- checkbox and radio inputs should now be directly clickable, and have a different DOM wrapper
- use EuiTitle size and font weight instead
- `.spcShareToSpaceIncludeRelated` isn't actually used anywhere in Kibana
- EuiCheckbox DOM has changed since, color: inherit should work for both disabled and non-disabled checkboxes
…ons with components instead - in the cast of the `prepend` prop, `<EuiFormLabel>` is already automatically used if the prepend type is a string
- EuiFormControlLayout should automatically handle styling, and prepend/append nodes shouldn't be used outside of form layouts
…Group`s - EuiDescribedFormGroups already automatically accounts for form rows without labels, so the `hasEmptyLabelSpace` prop is now unnecessary and adds extra unwanted spacing
- contains all the backports + several requested new features from Kibana consumers
- remove now-unnecessary unsets or importants - tweak heights/vertical centering etc - [feat] rewrite range slider CSS in Emotion vs Sass + with new CSS variables etc
- doesn't apply and isn't necessary, removing it gets the button group back to the previous prod rendering
mgadewoll
added
ci:cloud-deploy
Contributor
Author
|
buildkite test this |
⏳ Build in-progress, with failuresFailed CI Steps
Test Failures
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is only a testing branch and should not be merged.
This Draft PR is based of a non-merged EUI update PR to ensure parity. (Hence additional changes)