[8.15] [Security Solution] [Attack discovery] Fixes a flakey jest test (#191736)#191774
Merged
kibanamachine merged 1 commit intoelastic:8.15from Aug 29, 2024
Merged
Conversation
…tic#191736) Fixes a flakey jest test that failed twice since it was introduced ~2 months ago in [this pr](elastic#186679), as tracked by elastic#189757 ### CI and desk flake testing To test the fix for fakyness, it ran `10,000` times in CI, and locally, with a `100%` success rate. (The test was wrapped in a loop to execute 10,000 times.) - Tested in CI 10,000 times via following Buildkite build: :green_heart: Build Succeeded [Buildkite Build](https://buildkite.com/elastic/kibana-pull-request/builds/230901) The 10,000 passing test runs are included in the following (abbreviated) build log output: ``` Ran all test suites. $ node scripts/jest --config x-pack/plugins/security_solution/public/attack_discovery/jest.config.js actual full command is: NODE_OPTIONS="--max-old-space-size=12288 --trace-warnings" node ./scripts/jest --config="x-pack/plugins/security_solution/public/attack_discovery/jest.config.js" --runInBand --coverage=false --passWithNoTests PASS x-pack/plugins/security_solution/public/attack_discovery/pages/loading_callout/countdown/index.test.tsx (742.054 s) # other passing tests... Test Suites: 54 passed, 54 total Tests: 10297 passed, 10297 total Snapshots: 0 total Time: 962.106 s ``` - Tested locally 10,000 times, as illustrated by the following console output: ``` ✓ renders the expected the timer text - iteration 9996 (43 ms) ✓ renders the expected the timer text - iteration 9997 (44 ms) ✓ renders the expected the timer text - iteration 9998 (48 ms) ✓ renders the expected the timer text - iteration 9999 (49 ms) ✓ renders the expected the timer text - iteration 10000 (46 ms) Test Suites: 1 passed, 1 total Tests: 10002 passed, 10002 total Snapshots: 0 total Time: 294.54 s Ran all test suites matching /x-pack\/plugins\/security_solution\/public\/attack_discovery\/pages\/loading_callout\/countdown\/index.test.tsx/i. ``` (cherry picked from commit e0f8eb1)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.15:Questions ?
Please refer to the Backport tool documentation