Skip to content

[ES|QL] Support argument precedence in BasicPrettyPrinter#191727

Merged
vadimkibana merged 1 commit intoelastic:mainfrom
vadimkibana:expression-precedence
Aug 29, 2024
Merged

[ES|QL] Support argument precedence in BasicPrettyPrinter#191727
vadimkibana merged 1 commit intoelastic:mainfrom
vadimkibana:expression-precedence

Conversation

@vadimkibana
Copy link
Copy Markdown
Contributor

Summary

Inserts brackets where necessary, if binary expressions have different precedence. For example:

FROM a | WHERE (1 + 2) * (3 - 4)

Checklist

For maintainers

@vadimkibana vadimkibana requested a review from a team as a code owner August 29, 2024 11:36
@vadimkibana vadimkibana added bug Fixes for quality problems that affect the customer experience review release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v8.16.0 labels Aug 29, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@vadimkibana vadimkibana enabled auto-merge (squash) August 29, 2024 11:38
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana merged commit a156e67 into elastic:main Aug 29, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:ESQL ES|QL related features in Kibana t// v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants