Skip to content

[ML] Improve expired license check#191503

Merged
jgowdyelastic merged 2 commits intoelastic:mainfrom
jgowdyelastic:improve-expired-license-check
Aug 29, 2024
Merged

[ML] Improve expired license check#191503
jgowdyelastic merged 2 commits intoelastic:mainfrom
jgowdyelastic:improve-expired-license-check

Conversation

@jgowdyelastic
Copy link
Member

When a trial license expires, the license falls into a state where it is not seen as being a valid basic license, but rather an "expired" license.
The license is still valid and our isMinimumLicense check needs to return true in this situation to allow the ML app to redirect to the expired license page.

Before (ML page fails to load):

image

After (we redirect to the license page):

image

@jgowdyelastic jgowdyelastic self-assigned this Aug 27, 2024
@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix :ml v8.16.0 labels Aug 27, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review August 27, 2024 14:10
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 27, 2024 14:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 80.5KB 80.5KB +15.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jgowdyelastic jgowdyelastic merged commit 0a1be16 into elastic:main Aug 29, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience :ml release_note:fix v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants