[Response Ops][Cases] Spinner on assigning user to case from case page#191490
Merged
jcger merged 4 commits intoelastic:mainfrom Aug 29, 2024
Merged
[Response Ops][Cases] Spinner on assigning user to case from case page#191490jcger merged 4 commits intoelastic:mainfrom
jcger merged 4 commits intoelastic:mainfrom
Conversation
jcger
changed the title
jcger
added
Team:ResponseOps
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
jcger
changed the title
jcger
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
js-jankisalvi
approved these changes
Aug 29, 2024
Contributor
js-jankisalvi
left a comment
js-jankisalvi
left a comment
There was a problem hiding this comment.
Verified locally, works as expected 👍
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 29, 2024
elastic#191490) ## Summary Fixes elastic#190303 In 8.15 we disabled a request that showed a spinner while React Query's `isLoading` was true. `isLoading` remains true as long as no data has been received. Because the request was disabled, `isLoading` stayed true the entire time, causing the spinner to be displayed instead of the form that would have activated the request. The fix uses another React Query state called `isFetching`, which is only true while the request is actively being made, so initially, no spinner is shown. ## Release Note Fix endless loading spinner when wanting to add a assignee to a case from the cases list (cherry picked from commit 19f6469)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 29, 2024
…ase page (#191490) (#191725) # Backport This will backport the following commits from `main` to `8.15`: - [[Response Ops][Cases] Spinner on assigning user to case from case page (#191490)](#191490) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julian Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-08-29T11:08:33Z","message":"[Response Ops][Cases] Spinner on assigning user to case from case page (#191490)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190303\r\n\r\nIn 8.15 we disabled a request that showed a spinner while React Query's\r\n`isLoading` was true. `isLoading` remains true as long as no data has\r\nbeen received. Because the request was disabled, `isLoading` stayed true\r\nthe entire time, causing the spinner to be displayed instead of the form\r\nthat would have activated the request. The fix uses another React Query\r\nstate called `isFetching`, which is only true while the request is\r\nactively being made, so initially, no spinner is shown.\r\n\r\n## Release Note\r\nFix endless loading spinner when wanting to add a assignee to a case\r\nfrom the cases list","sha":"19f6469be705d88ec8f3b803e349257d45603f09","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Feature:Cases","v8.15.0","v8.16.0"],"title":"[Response Ops][Cases] Spinner on assigning user to case from case page","number":191490,"url":"https://github.com/elastic/kibana/pull/191490","mergeCommit":{"message":"[Response Ops][Cases] Spinner on assigning user to case from case page (#191490)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190303\r\n\r\nIn 8.15 we disabled a request that showed a spinner while React Query's\r\n`isLoading` was true. `isLoading` remains true as long as no data has\r\nbeen received. Because the request was disabled, `isLoading` stayed true\r\nthe entire time, causing the spinner to be displayed instead of the form\r\nthat would have activated the request. The fix uses another React Query\r\nstate called `isFetching`, which is only true while the request is\r\nactively being made, so initially, no spinner is shown.\r\n\r\n## Release Note\r\nFix endless loading spinner when wanting to add a assignee to a case\r\nfrom the cases list","sha":"19f6469be705d88ec8f3b803e349257d45603f09"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191490","number":191490,"mergeCommit":{"message":"[Response Ops][Cases] Spinner on assigning user to case from case page (#191490)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190303\r\n\r\nIn 8.15 we disabled a request that showed a spinner while React Query's\r\n`isLoading` was true. `isLoading` remains true as long as no data has\r\nbeen received. Because the request was disabled, `isLoading` stayed true\r\nthe entire time, causing the spinner to be displayed instead of the form\r\nthat would have activated the request. The fix uses another React Query\r\nstate called `isFetching`, which is only true while the request is\r\nactively being made, so initially, no spinner is shown.\r\n\r\n## Release Note\r\nFix endless loading spinner when wanting to add a assignee to a case\r\nfrom the cases list","sha":"19f6469be705d88ec8f3b803e349257d45603f09"}}]}] BACKPORT--> Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
cnasikas
added
the
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #190303
In 8.15 we disabled a request that showed a spinner while React Query's
isLoadingwas true.isLoadingremains true as long as no data has been received. Because the request was disabled,isLoadingstayed true the entire time, causing the spinner to be displayed instead of the form that would have activated the request. The fix uses another React Query state calledisFetching, which is only true while the request is actively being made, so initially, no spinner is shown.Release Note
Fix endless loading spinner when wanting to add a assignee to a case from the cases list