[ES|QL] Only log requests to Inspector on request complete#191232
Merged
lukasolson merged 9 commits intoelastic:mainfrom Aug 29, 2024
Merged
[ES|QL] Only log requests to Inspector on request complete#191232lukasolson merged 9 commits intoelastic:mainfrom
lukasolson merged 9 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6823[✅] test/functional/apps/discover/esql/config.ts: 25/25 tests passed. |
lukasolson
added
release_note:fix
Team:DataDiscovery
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
nreese
approved these changes
Aug 28, 2024
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @lukasolson |
davismcphee
approved these changes
Aug 29, 2024
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Code changes look good, and it works well 👍 Thanks for fixing this!
Contributor
|
Awesome Lukas 🙇 |
dej611
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requires #191520.
Resolves #188266.
Prior to this PR, when polling on an async ES|QL request, we would log the response to every polling request. This PR only logs when the request is complete.
Before:
After:
Checklist