Skip to content

[Unified Search][Lens] Focus selectable search inputs in dropdowns#191213

Merged
mbondyra merged 3 commits intoelastic:mainfrom
nickofthyme:auto-focus-inputs
Aug 26, 2024
Merged

[Unified Search][Lens] Focus selectable search inputs in dropdowns#191213
mbondyra merged 3 commits intoelastic:mainfrom
nickofthyme:auto-focus-inputs

Conversation

@nickofthyme
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme commented Aug 23, 2024

Summary

Adds autoFocus search input in dropdown for the global Data view selector and the Lens chart switch. Now clicking on either dropdown, the focus will automatically be on the input for the user to start typing to filter selectable items. This does not change the tab indexing of the surrounding elements.

Data view picker

Zight Recording 2024-08-23 at 09 11 47 AM

Lens chart switch

Zight Recording 2024-08-23 at 09 14 09 AM

closes #189686

Checklist

@nickofthyme nickofthyme added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Aug 23, 2024
@nickofthyme nickofthyme requested a review from a team as a code owner August 23, 2024 16:21
@nickofthyme nickofthyme requested review from a team and davismcphee August 23, 2024 16:22
@nickofthyme nickofthyme added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Aug 23, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nickofthyme nickofthyme added the Feature:Unified search Unified search related tasks label Aug 23, 2024
@nickofthyme nickofthyme changed the title Focus selectable search inputs in dropdowns [Unified Search] Focus selectable search inputs in dropdowns Aug 23, 2024
@nickofthyme nickofthyme changed the title [Unified Search] Focus selectable search inputs in dropdowns [Unified Search][Lens] Focus selectable search inputs in dropdowns Aug 23, 2024
Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Simple and it works, LGTM 👍

@mbondyra
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@mbondyra mbondyra enabled auto-merge (squash) August 26, 2024 20:29
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #81 / Visualizations - Group 3 lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 219.0KB 219.0KB +39.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit 64f1ae6 into elastic:main Aug 26, 2024
@nickofthyme nickofthyme deleted the auto-focus-inputs branch August 28, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Lens Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Unified Search] The search input should be auto-focused when opening the data view picker

8 participants