[Unified Search][Lens] Focus selectable search inputs in dropdowns#191213
Merged
mbondyra merged 3 commits intoelastic:mainfrom Aug 26, 2024
Merged
[Unified Search][Lens] Focus selectable search inputs in dropdowns#191213mbondyra merged 3 commits intoelastic:mainfrom
mbondyra merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
davismcphee
approved these changes
Aug 23, 2024
Contributor
davismcphee
left a comment
There was a problem hiding this comment.
Nice! Simple and it works, LGTM 👍
dej611
approved these changes
Aug 26, 2024
Contributor
|
@elasticmachine merge upstream |
mbondyra
reviewed
Aug 26, 2024
…onfig_panel/chart_switch/chart_switch.tsx
mbondyra
approved these changes
Aug 26, 2024
MichaelMarcialis
approved these changes
Aug 26, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
autoFocussearch input in dropdown for the global Data view selector and the Lens chart switch. Now clicking on either dropdown, the focus will automatically be on the input for the user to start typing to filter selectable items. This does not change the tab indexing of the surrounding elements.Data view picker
Lens chart switch
closes #189686
Checklist