[ML] AIOps: Using no minimum time range by default for pattern analysis#191192
Conversation
jgowdyelastic
added
release_note:enhancement
:ml
Feature:ML/AIOps
|
Pinging @elastic/ml-ui (:ml) |
| import { i18n } from '@kbn/i18n'; | ||
| import type { unitOfTime } from 'moment'; | ||
|
|
||
| export const DEFAULT_MINIMUM_TIME_RANGE_OPTION: MinimumTimeRangeOption = 'No minimum'; |
There was a problem hiding this comment.
I think we could do with some clarification in the UI as to what 'No minimum' means? Possibly some text in the help tooltip, and some text below the 'Minimum time range' field if they have 'No minimum' selected. e.g. does it mean it will search right back to the start of the data in the data view, or just to the start date set in the time picker.
There was a problem hiding this comment.
Yeah I agree. I'm not sure what the text should say for the No minimum option.
The time range used will match the time picker ?
No additional time will be added to the range selected ?
@szabosteve do you have any ideas?
There was a problem hiding this comment.
@jgowdyelastic @peteharverson
I'd change the dropdown label to Use selected time.
And the helper text – if needed – could be something like:
The time range you specified using the time selector will be used for the analysis.
What do you think?
There was a problem hiding this comment.
I like the idea of changing the label in the dropdown from 'No minimum' to 'Use selected time' (or even 'Use range selected in time picker' to clarify which selected time?).
The only issue with The time range you specified using the time selector will be used for the analysis. for the help text is that it then begs the question of why wouldn't the analysis always used the selected time range? Maybe something along the lines of No additional time be added. ?
Very difficult to explain concisely what this setting relates to!
There was a problem hiding this comment.
What about the following as the helper text?
No additional time is added to the range you specified with the time selector.
However, if the selector label is changed to Use range specified in time selector or something along these lines, then I don't think a helper text is necessary.
There was a problem hiding this comment.
Nit - I think the form help texts normally end with a .
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
LGTM - think it's just worth adding the closing . to the help text.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
7 participants
Changing the default selection from
1 weektoNo minimum.For indices with very large doc counts, it is safer not to query a week's worth of data by default, but rather use the time range selected in the time picker.