[Security Solution] migrate Threat Intelligence Cypress tests into security_solution_cypress folder#191162
Merged
PhilippeOberti merged 3 commits intoelastic:mainfrom Sep 11, 2024
Conversation
This was referenced Aug 23, 2024
b820920 to
1c6d069
Compare
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6804[❌] Security Solution Investigations - Cypress: 0/25 tests passed. |
1c6d069 to
aa93791
Compare
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6805[✅] [Serverless] Security Solution Investigations - Cypress: 25/25 tests passed. |
TinaHeiligers
approved these changes
Aug 29, 2024
Contributor
TinaHeiligers
left a comment
There was a problem hiding this comment.
changes to the plugin manifest LGTM
MadameSheema
approved these changes
Sep 4, 2024
lgestc
approved these changes
Sep 10, 2024
Contributor
lgestc
left a comment
There was a problem hiding this comment.
looking okay, we finally have something working here again :) thanks!
…curity_solution_cypress folder
This reverts commit 3867f2a.
aa93791 to
97d994b
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Sep 11, 2024
This was referenced Sep 11, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first of 3 that aims at migrating all the Threat Intelligence Cypress tests to the
security_solution_cypressfolder. The goal is to re-enable the Threat Intelligence tests that have been skipped for months now, which has lead to many issues that were covered by those tests not being detected...This PR covers:
security_solution_cypressfolder within the existinginvestigationsfolder, to ensure they're running alongside all the other tests owned by the @elastic/security-threat-hunting-investigations teamgetDataTestSubjectSelectorfunction wherever possibleforce: trueandshould('exist')orshould('be.visible')as well asscrollIntoViewcodeThe next 2 PRS will tackle the following:
plugins/threat_intelligencefolder as well as all the code under thetest/threat_intelligence_cypressfolder)Checklist
✅ Flaky Test Runner all passed here https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6805
#171778
#171779
#171780
#171781
#171783
#171784
#171785
#171786
It also fixes this bug