-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Refresh dashboards docs #191129
[Docs] Refresh dashboards docs #191129
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great changes and make the docs much easier to follow. Just a few questions/comments but nothing major
image::images/dashboard-global-time-range.png[Time range menu with multiple time range suggestions, width=40%] | ||
|
||
[float] | ||
==== Apply a custom time filter on a panel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using "time range" instead of "time filter". In the intro section, you referred to it as "or specify a custom time range for each panel." and I think you should stay consistent with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I may have mixed up some things here as "time range" is also the term that appears in the UI 👍 Changing it in the various places where I've used it incorrectly
|
||
**To view and edit panel-level filters:** | ||
|
||
When a custom filter is active for a single panel, it is indicated in the panel's header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indicator is only displayed in edit mode, so how about something like "When a custom filter is active for a single panel, it is indicated in the panel's header when the dashboard is in Edit mode."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see now, that section was meant to be about the time range, and TBH I didn't even notice that filter icon ^^' but I now get the confusion. I will make some changes to make this clearer. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a quick edit and will treat the whole "View panel data and requests" section (including this item) separately, as it requires more work https://github.com/elastic/platform-docs-team/issues/468
|
||
. Enter the time range you want to view, then *Apply* it. | ||
|
||
**To view and edit panel-level filters:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to move this section to "View the panel data and requests" so the order follows the intro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This specifically applies to the custom time range so I would tend to leave it there. That said, I've added a mention of this to that other section as well.
|
||
When a custom filter is active for a single panel, it is indicated in the panel's header. | ||
|
||
To edit it, click the filter in the header. You can then adjust and apply the updated **Time range**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are referring to custom filter for the panel instead of "Time range"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ | ||
When you create a dashboard, you are automatically in edit mode and can make changes to the dashboard. | ||
[[create-panels-with-lens]] | ||
. Add content to the dashboard. You have several options covered in more details in the <<panels-editors,Visualizations section>>: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really clean and concise description of these very confusing options.
. Organize your dashboard by <<arrange-panels,organizing the various panels>>. | ||
[[add-dashboard-settings]] | ||
. Define the main settings of your dashboard from the *Settings* menu located in the toolbar. | ||
.. Clear title, description, and <<managing-tags,tags>> allow you to find the dashboard quickly later when browsing your list of dashboard or using the {kib} search bar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better word for "clear". When I first read this I thought of the verb "clear" instead of an adjective. Maybe something that can not be mistaken for an action on title would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, and I usually don't add adjectives like that in the docs "clear, simple, easy" as this is usually us trying to project our own wishes to the user. I'm changing it to "Meaningful".
* *Selection* settings: | ||
|
||
** *Validate user selections* — When selected, any selected option that results in no data is ignored. | ||
** *Chain controls* — When selected, any selected options in one control narrows the available options in the next control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "When selected, any selected options in one control narrows the available options in controls to the right of the control with the selected options."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited it this way, how does that sound to you?:
"When selected, controls are applied sequentially from left to right, and line by line. Any selected options in one control narrows the available options in the next control."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that a lot. Thanks for adding
Latest edits include:
These changes are fairly small so I didn't rebuild the preview. |
@teresaalvarezsoler @nreese After a few rounds of edits, I think we're in a pretty good spot compared to the current docs. Outstanding items are captured in several follow up issues (screenshots, Lens, Chart types page, view panel data and filters...). Let me know what you think and if we're good to move forward with this updated structure and content. And thanks a lot for your reviews and input!! |
|
||
**To view and edit the time range applied to a specific panel:** | ||
|
||
When a custom filter is active for a single panel, it is indicated in the panel's header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about changing "custom filter" to "custom time range" to avoid confusion with panel filters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 I thought I did. Done now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for updating the dashboard documentation.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
This reverts commit 6d87f5f.
This was reverted. See https://buildkite.com/elastic/docs-build-pr/builds/139739#0191c867-8422-4698-a8a5-d800f6abac8d. |
Hey @jbudz Thanks for the note. The file causing the error on the job you shared is updated with the correct links in this PR. So I'm not sure of where the error is coming from 🤔. Do you have an idea? |
## Summary This PR updates the structure of the Dashboards docs and refreshes some outdated parts of the content. More updates will be made in future PRs to refresh screenshots and to refresh the content more in depth. This new structure and edits: - distribute the pages in more user-oriented identified themes, for better findability, scanning, and to ease possible integration of some of these pages into in-app documentation. - are more future proof to evolve along with upcoming features. ~I'll leave this PR as a draft until I resolve some link dependencies coming from other docs sources and check some additional bits of content.~ Preview available on demand on Slack. Closes: elastic/platform-docs-team#408 (I'll create separate issues for remaining items) Closes: elastic/platform-docs-team#413 Closes: elastic/platform-docs-team#418
@florent-leborgne the docs team will be able to give you a better explanation, but I'm guessing the link changes are failing to validate against older branches. Probably needs to have |
## Summary [redo of #191129 that got reverted] This PR updates the structure of the Dashboards docs and refreshes some outdated parts of the content. More updates will be made in future PRs to refresh screenshots and to refresh the content more in depth. This new structure and edits: - distribute the pages in more user-oriented identified themes, for better findability, scanning, and to ease possible integration of some of these pages into in-app documentation. - are more future proof to evolve along with upcoming features. ~I'll leave this PR as a draft until I resolve some link dependencies coming from other docs sources and check some additional bits of content.~ Preview available on demand on Slack. Closes: elastic/platform-docs-team#408 (I'll create separate issues for remaining items) Closes: elastic/platform-docs-team#413 Closes: elastic/platform-docs-team#418 --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Lisa Cawley <[email protected]>
Summary
This PR updates the structure of the Dashboards docs and refreshes some outdated parts of the content.
More updates will be made in future PRs to refresh screenshots and to refresh the content more in depth.
This new structure and edits:
I'll leave this PR as a draft until I resolve some link dependencies coming from other docs sources and check some additional bits of content.Preview available on demand on Slack.
Closes: https://github.com/elastic/platform-docs-team/issues/408 (I'll create separate issues for remaining items)
Closes: https://github.com/elastic/platform-docs-team/issues/413
Closes: https://github.com/elastic/platform-docs-team/issues/418