Skip to content

[Lens] Make title align left correctly after removing icon in Metric chart#191057

Merged
dej611 merged 7 commits intoelastic:mainfrom
dej611:fix/190765
Aug 29, 2024
Merged

[Lens] Make title align left correctly after removing icon in Metric chart#191057
dej611 merged 7 commits intoelastic:mainfrom
dej611:fix/190765

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Aug 22, 2024

Summary

Fixes #190765

metric_title_fix

@dej611 dej611 added release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:Lens v8.16.0 labels Aug 22, 2024
@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Aug 22, 2024

/ci

@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Aug 22, 2024

/ci

@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Aug 26, 2024

/ci

@dej611 dej611 marked this pull request as ready for review August 26, 2024 14:51
@dej611 dej611 requested a review from a team as a code owner August 26, 2024 14:51
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1513 1510 -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/visualization-ui-components 134 138 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
eventAnnotationListing 312.0KB 312.9KB +865.0B
lens 1.5MB 1.5MB -617.0B
total +248.0B
Unknown metric groups

API count

id before after diff
@kbn/visualization-ui-components 137 144 +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 631304b into elastic:main Aug 29, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Lens] Cannot restore left title alignment in metric after adding an icon

5 participants