[controls] Refactor control group settings functional tests#190999
Merged
nreese merged 9 commits intoelastic:mainfrom Aug 22, 2024
Merged
[controls] Refactor control group settings functional tests#190999nreese merged 9 commits intoelastic:mainfrom
nreese merged 9 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
1 similar comment
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
nreese
changed the title
nreese
added
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ThomThomson
approved these changes
Aug 22, 2024
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Test changes LGTM! Looked through the tests to ensure that all test coverage was retained. Great to see functional tests get converted into unit tests, and great to see the reduction in CI time.
| ]; | ||
|
|
||
| interface EditControlGroupProps { | ||
| interface Props { |
Contributor
There was a problem hiding this comment.
nit: if this type isn't exported or used more than once - why not inline it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor control group settings tests
Before
Tests take 4 minutes to run locally
After
Tests take 1 minute to run locally
