[Detection Engine] update data view select to include name and title#190936
Closed
yctercero wants to merge 5 commits intoelastic:mainfrom
Closed
[Detection Engine] update data view select to include name and title#190936yctercero wants to merge 5 commits intoelastic:mainfrom
yctercero wants to merge 5 commits intoelastic:mainfrom
Conversation
yctercero
added
release_note:enhancement
Team:Detection Engine
Contributor
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Async chunks
HistoryTo update your PR or re-run it, just comment with: cc @yctercero |
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6792[❌] Security Solution Detection Engine - Cypress: 0/25 tests passed. |
Contributor
Author
|
@ARWNightingale could you re-review this PR. With the changes from the prebuilt rule customization work, the component changed and it's no longer as easy to include both the name and underlying index patterns. This PR would change it to just show names and add a helper text that explains this. |
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Mar 13, 2025
This ports Yara's code from elastic#190936 to a new branch based on the latest upstream. Conflicts: x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/components/step_define_rule/schema.tsx
2 tasks
Contributor
Author
|
Addressed in #214495 |
rylnd
added a commit
that referenced
this pull request
Mar 20, 2025
…lay (#214495) ## Summary Supersedes #190936, and also addresses #137823. This mainly just rebases the changes introduced there to the latest `main`. I also noticed that it originally had some unit tests, so I resurrected those as well. ~~I modified the copy as well, so nota bene @ARWNightingale~~ After some discussion, we determined that an explicit UI note about this behavior was unnecessary. ## Screenshots <kbd> <img width="979" alt="Screenshot 2025-03-13 at 5 24 42 PM" src="https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59" /></kbd> <kbd><img width="1052" alt="Screenshot 2025-03-18 at 4 37 58 PM" src="https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1" /></kbd> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Yara Tercero <yara.tercero@elastic.co>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 20, 2025
…lay (elastic#214495) ## Summary Supersedes elastic#190936, and also addresses elastic#137823. This mainly just rebases the changes introduced there to the latest `main`. I also noticed that it originally had some unit tests, so I resurrected those as well. ~~I modified the copy as well, so nota bene @ARWNightingale~~ After some discussion, we determined that an explicit UI note about this behavior was unnecessary. ## Screenshots <kbd> <img width="979" alt="Screenshot 2025-03-13 at 5 24 42 PM" src="https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59" /></kbd> <kbd><img width="1052" alt="Screenshot 2025-03-18 at 4 37 58 PM" src="https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1" /></kbd> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Yara Tercero <yara.tercero@elastic.co> (cherry picked from commit 07acd24)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 20, 2025
…lay (elastic#214495) ## Summary Supersedes elastic#190936, and also addresses elastic#137823. This mainly just rebases the changes introduced there to the latest `main`. I also noticed that it originally had some unit tests, so I resurrected those as well. ~~I modified the copy as well, so nota bene @ARWNightingale~~ After some discussion, we determined that an explicit UI note about this behavior was unnecessary. ## Screenshots <kbd> <img width="979" alt="Screenshot 2025-03-13 at 5 24 42 PM" src="https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59" /></kbd> <kbd><img width="1052" alt="Screenshot 2025-03-18 at 4 37 58 PM" src="https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1" /></kbd> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Yara Tercero <yara.tercero@elastic.co> (cherry picked from commit 07acd24)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 20, 2025
…lay (elastic#214495) ## Summary Supersedes elastic#190936, and also addresses elastic#137823. This mainly just rebases the changes introduced there to the latest `main`. I also noticed that it originally had some unit tests, so I resurrected those as well. ~~I modified the copy as well, so nota bene @ARWNightingale~~ After some discussion, we determined that an explicit UI note about this behavior was unnecessary. ## Screenshots <kbd> <img width="979" alt="Screenshot 2025-03-13 at 5 24 42 PM" src="https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59" /></kbd> <kbd><img width="1052" alt="Screenshot 2025-03-18 at 4 37 58 PM" src="https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1" /></kbd> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Yara Tercero <yara.tercero@elastic.co> (cherry picked from commit 07acd24)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 20, 2025
…lay (elastic#214495) ## Summary Supersedes elastic#190936, and also addresses elastic#137823. This mainly just rebases the changes introduced there to the latest `main`. I also noticed that it originally had some unit tests, so I resurrected those as well. ~~I modified the copy as well, so nota bene @ARWNightingale~~ After some discussion, we determined that an explicit UI note about this behavior was unnecessary. ## Screenshots <kbd> <img width="979" alt="Screenshot 2025-03-13 at 5 24 42 PM" src="https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59" /></kbd> <kbd><img width="1052" alt="Screenshot 2025-03-18 at 4 37 58 PM" src="https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1" /></kbd> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Yara Tercero <yara.tercero@elastic.co> (cherry picked from commit 07acd24)
kibanamachine
added a commit
that referenced
this pull request
Mar 20, 2025
…or display (#214495) (#215353) # Backport This will backport the following commits from `main` to `8.18`: - [[Detection Engine] Rule Data View select uses Data View name for display (#214495)](#214495) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ryland Herrick","email":"ryalnd@gmail.com"},"sourceCommit":{"committedDate":"2025-03-20T15:01:26Z","message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Rule Creation","backport:all-open","Team:Detection Engine","Feature:Rule Edit","v9.1.0"],"title":"[Detection Engine] Rule Data View select uses Data View name for display","number":214495,"url":"https://github.com/elastic/kibana/pull/214495","mergeCommit":{"message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214495","number":214495,"mergeCommit":{"message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8"}}]}] BACKPORT--> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 20, 2025
…r display (#214495) (#215355) # Backport This will backport the following commits from `main` to `9.0`: - [[Detection Engine] Rule Data View select uses Data View name for display (#214495)](#214495) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ryland Herrick","email":"ryalnd@gmail.com"},"sourceCommit":{"committedDate":"2025-03-20T15:01:26Z","message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Rule Creation","backport:all-open","Team:Detection Engine","Feature:Rule Edit","v9.1.0"],"title":"[Detection Engine] Rule Data View select uses Data View name for display","number":214495,"url":"https://github.com/elastic/kibana/pull/214495","mergeCommit":{"message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214495","number":214495,"mergeCommit":{"message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8"}}]}] BACKPORT--> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 20, 2025
…or display (#214495) (#215351) # Backport This will backport the following commits from `main` to `8.17`: - [[Detection Engine] Rule Data View select uses Data View name for display (#214495)](#214495) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ryland Herrick","email":"ryalnd@gmail.com"},"sourceCommit":{"committedDate":"2025-03-20T15:01:26Z","message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Rule Creation","backport:all-open","Team:Detection Engine","Feature:Rule Edit","v9.1.0"],"title":"[Detection Engine] Rule Data View select uses Data View name for display","number":214495,"url":"https://github.com/elastic/kibana/pull/214495","mergeCommit":{"message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214495","number":214495,"mergeCommit":{"message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8"}}]}] BACKPORT--> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 20, 2025
…r display (#214495) (#215354) # Backport This will backport the following commits from `main` to `8.x`: - [[Detection Engine] Rule Data View select uses Data View name for display (#214495)](#214495) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ryland Herrick","email":"ryalnd@gmail.com"},"sourceCommit":{"committedDate":"2025-03-20T15:01:26Z","message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Rule Creation","backport:all-open","Team:Detection Engine","Feature:Rule Edit","v9.1.0"],"title":"[Detection Engine] Rule Data View select uses Data View name for display","number":214495,"url":"https://github.com/elastic/kibana/pull/214495","mergeCommit":{"message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214495","number":214495,"mergeCommit":{"message":"[Detection Engine] Rule Data View select uses Data View name for display (#214495)\n\n## Summary\n\nSupersedes #190936, and also addresses\nhttps://github.com//issues/137823. This mainly just\nrebases the changes introduced there to the latest `main`. I also\nnoticed that it originally had some unit tests, so I resurrected those\nas well. ~~I modified the copy as well, so nota bene @ARWNightingale~~\nAfter some discussion, we determined that an explicit UI note about this\nbehavior was unnecessary.\n\n\n## Screenshots\n\n<kbd>\n<img width=\"979\" alt=\"Screenshot 2025-03-13 at 5 24 42 PM\"\nsrc=\"https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59\"\n/></kbd>\n\n<kbd><img width=\"1052\" alt=\"Screenshot 2025-03-18 at 4 37 58 PM\"\nsrc=\"https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1\"\n/></kbd>\n\n\n\n\n### Checklist\n\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Yara Tercero <yara.tercero@elastic.co>","sha":"07acd2480aea52d22a5c5454740cd2a1fa7a70e8"}}]}] BACKPORT--> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Mar 20, 2025
…lay (elastic#214495) ## Summary Supersedes elastic#190936, and also addresses elastic#137823. This mainly just rebases the changes introduced there to the latest `main`. I also noticed that it originally had some unit tests, so I resurrected those as well. ~~I modified the copy as well, so nota bene @ARWNightingale~~ After some discussion, we determined that an explicit UI note about this behavior was unnecessary. ## Screenshots <kbd> <img width="979" alt="Screenshot 2025-03-13 at 5 24 42 PM" src="https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59" /></kbd> <kbd><img width="1052" alt="Screenshot 2025-03-18 at 4 37 58 PM" src="https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1" /></kbd> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Yara Tercero <yara.tercero@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Mar 24, 2025
…lay (elastic#214495) ## Summary Supersedes elastic#190936, and also addresses elastic#137823. This mainly just rebases the changes introduced there to the latest `main`. I also noticed that it originally had some unit tests, so I resurrected those as well. ~~I modified the copy as well, so nota bene @ARWNightingale~~ After some discussion, we determined that an explicit UI note about this behavior was unnecessary. ## Screenshots <kbd> <img width="979" alt="Screenshot 2025-03-13 at 5 24 42 PM" src="https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59" /></kbd> <kbd><img width="1052" alt="Screenshot 2025-03-18 at 4 37 58 PM" src="https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1" /></kbd> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Yara Tercero <yara.tercero@elastic.co>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…lay (elastic#214495) ## Summary Supersedes elastic#190936, and also addresses elastic#137823. This mainly just rebases the changes introduced there to the latest `main`. I also noticed that it originally had some unit tests, so I resurrected those as well. ~~I modified the copy as well, so nota bene @ARWNightingale~~ After some discussion, we determined that an explicit UI note about this behavior was unnecessary. ## Screenshots <kbd> <img width="979" alt="Screenshot 2025-03-13 at 5 24 42 PM" src="https://github.com/user-attachments/assets/69da29bf-5504-461e-b797-d016adcd4b59" /></kbd> <kbd><img width="1052" alt="Screenshot 2025-03-18 at 4 37 58 PM" src="https://github.com/user-attachments/assets/8ee5e55e-2413-4936-aa87-7dadb3d7cbb1" /></kbd> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Yara Tercero <yara.tercero@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #137823
How to test
Go to rule creation and play around with data view selection! That's it. Make sure that it is rendered correctly, and that on save, it is saved as intended.
Checklist