[Synthetics] Settings add config to enable default rules#190800
[Synthetics] Settings add config to enable default rules#190800shahzad31 merged 19 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
added
the
release_note:feature
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
x-pack/plugins/observability_solution/synthetics/server/alert_rules/common.ts
Show resolved
Hide resolved
...ins/observability_solution/synthetics/server/alert_rules/status_rule/status_rule_executor.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/synthetics/server/queries/query_monitor_status.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/synthetics/server/routes/certs/get_certificates.ts
Show resolved
Hide resolved
...gins/observability_solution/synthetics/server/routes/default_alerts/default_alert_service.ts
Outdated
Show resolved
Hide resolved
| import { AlertInstanceState } from '@kbn/alerting-plugin/server'; | ||
| import { AlertInstanceContext } from '@kbn/alerting-plugin/server'; | ||
| import { uptimeRuleFieldMap } from '../../../../common/rules/uptime_rule_field_map'; | ||
| import { syntheticsRuleFieldMap } from '@kbn/synthetics-plugin/common/rules/synthetics_rule_field_map'; |
There was a problem hiding this comment.
I want to thoroughly avoid changes to Uptime. I feel like any kind of unnecessary change raises the risk matrix for having to deal with Uptime SDHs, and we certainly don't have time for that. I don't think this is a necessary change.
There was a problem hiding this comment.
this should be reverted, will do it.
dominiqueclarke
left a comment
dominiqueclarke
left a comment
There was a problem hiding this comment.
The disabling doesn't appear to work as expected. I still received an alert and the rule appears to still be enabled from management. I would expect that this setting actually disables the default rule from the alerting side
With that in mind, maybe we should create new settings for this purpose, but instead use the rule state as the single source of truth
On this page we can fetch the default rule as see if it's enabled, then the toggle will be one. When the user clicks the toggle off and saves, it'll just disable the rule from the alerting plugin.
dominiqueclarke
force-pushed
the
default-rules-config
branch
from
ed33f0d to
858fc19
Compare
| statusRule, | ||
| tlsRule, | ||
| }; | ||
| const deleteStatusRulePromise = |
There was a problem hiding this comment.
We should move this into the DefaultAlertService.
jeramysoucy
left a comment
jeramysoucy
left a comment
There was a problem hiding this comment.
AppEx Security changes LGTM. No ESO changes.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
7 participants
Summary
Settings add config to enable default rules !!
separated out of #186585 !!