Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows][MKI][Osquery] Osquery Cypress tests in MKI #190675

Merged
merged 44 commits into from
Aug 20, 2024

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented Aug 19, 2024

This PR introduces osquery Cypress tests to the MKI environment. These tests will be executed within the Kibana / Serverless / Security Solution Quality Gate / Defend Workflows scope. You can find an example of the build here: Buildkite Example.

The main challenge with running osquery tests in MKI is that we cannot continuously log in users as we do in other environments. This is due to an issue where users are logged out when switching apps. To address this, I've added a simple check in the login method to prevent the login function from being called unnecessarily in MKI. This is a temporary solution until we can properly log in users via API calls using authentication tokens.

All the chalk & log.indent changes were made to make logs more beautiful 😸
Screenshot 2024-08-09 at 13 00 50

@szwarckonrad szwarckonrad changed the title Osquery mki [EDR Workflows][MKI][Osquery] Osquery Cypress tests in MKI Aug 19, 2024
@szwarckonrad szwarckonrad self-assigned this Aug 19, 2024
@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 labels Aug 19, 2024
@szwarckonrad szwarckonrad requested review from tomsonpl and jbudz August 19, 2024 09:03
@szwarckonrad szwarckonrad marked this pull request as ready for review August 19, 2024 09:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szwarckonrad szwarckonrad enabled auto-merge (squash) August 20, 2024 07:25
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
osquery 118 119 +1

Total ESLint disabled count

id before after diff
osquery 118 119 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@szwarckonrad szwarckonrad merged commit 7027b0b into elastic:main Aug 20, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants