-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDR Workflows][MKI][Osquery] Osquery Cypress tests in MKI #190675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
tomsonpl
approved these changes
Aug 19, 2024
maximpn
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbudz
reviewed
Aug 19, 2024
...kite/pipelines/security_solution_quality_gate/mki_periodic/mki_periodic_defend_workflows.yml
Outdated
Show resolved
Hide resolved
jbudz
approved these changes
Aug 19, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces osquery Cypress tests to the MKI environment. These tests will be executed within the Kibana / Serverless / Security Solution Quality Gate / Defend Workflows scope. You can find an example of the build here: Buildkite Example.
The main challenge with running osquery tests in MKI is that we cannot continuously log in users as we do in other environments. This is due to an issue where users are logged out when switching apps. To address this, I've added a simple check in the login method to prevent the login function from being called unnecessarily in MKI. This is a temporary solution until we can properly log in users via API calls using authentication tokens.
All the

chalk
&log.indent
changes were made to make logs more beautiful 😸