Skip to content

[ES|QL] Update function metadata #190667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewdaemon merged 2 commits into from
Aug 19, 2024
Merged

[ES|QL] Update function metadata #190667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e516953
Update function metadata
kibanamachine Aug 19, 2024
fb1913f
remove date nanos tests
drewdaemon Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions packages/kbn-esql-validation-autocomplete/src/definitions/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3268,16 +3268,6 @@ const mvCountDefinition: FunctionDefinition = {
],
returnType: 'integer',
},
{
params: [
{
name: 'field',
type: 'date_nanos',
optional: false,
},
],
returnType: 'integer',
},
{
params: [
{
Expand Down Expand Up @@ -3581,16 +3571,6 @@ const mvFirstDefinition: FunctionDefinition = {
],
returnType: 'cartesian_shape',
},
{
params: [
{
name: 'field',
type: 'date_nanos',
optional: false,
},
],
returnType: 'date_nanos',
},
{
params: [
{
Expand Down Expand Up @@ -3748,16 +3728,6 @@ const mvLastDefinition: FunctionDefinition = {
],
returnType: 'cartesian_shape',
},
{
params: [
{
name: 'field',
type: 'date_nanos',
optional: false,
},
],
returnType: 'date_nanos',
},
{
params: [
{
Expand Down Expand Up @@ -3895,16 +3865,6 @@ const mvMaxDefinition: FunctionDefinition = {
],
returnType: 'boolean',
},
{
params: [
{
name: 'field',
type: 'date_nanos',
optional: false,
},
],
returnType: 'date_nanos',
},
{
params: [
{
Expand Down Expand Up @@ -4085,16 +4045,6 @@ const mvMinDefinition: FunctionDefinition = {
],
returnType: 'boolean',
},
{
params: [
{
name: 'field',
type: 'date_nanos',
optional: false,
},
],
returnType: 'date_nanos',
},
{
params: [
{
Expand Down
55 changes: 0 additions & 55 deletions packages/kbn-esql-validation-autocomplete/src/validation/esql_validation_meta_tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16333,21 +16333,6 @@
"error": [],
"warning": []
},
{
"query": "from a_index | where mv_count(dateNanosField) > 0",
"error": [],
"warning": []
},
{
"query": "from a_index | eval var = mv_count(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "from a_index | eval mv_count(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "row var = mv_dedupe(true)",
"error": [],
Expand Down Expand Up @@ -17311,16 +17296,6 @@
"error": [],
"warning": []
},
{
"query": "from a_index | eval var = mv_first(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "from a_index | eval mv_first(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "row var = mv_last(true)",
"error": [],
Expand Down Expand Up @@ -17810,16 +17785,6 @@
"error": [],
"warning": []
},
{
"query": "from a_index | eval var = mv_last(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "from a_index | eval mv_last(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "row var = mv_max(true)",
"error": [],
Expand Down Expand Up @@ -18140,16 +18105,6 @@
"error": [],
"warning": []
},
{
"query": "from a_index | eval var = mv_max(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "from a_index | eval mv_max(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "row var = mv_median(5.5)",
"error": [],
Expand Down Expand Up @@ -18620,16 +18575,6 @@
"error": [],
"warning": []
},
{
"query": "from a_index | eval var = mv_min(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "from a_index | eval mv_min(dateNanosField)",
"error": [],
"warning": []
},
{
"query": "row var = mv_slice(true, 5, 5)",
"error": [],
Expand Down
11 changes: 0 additions & 11 deletions packages/kbn-esql-validation-autocomplete/src/validation/validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4473,9 +4473,6 @@ describe('validation logic', () => {
testErrorsAndWarnings('row mv_count(to_geopoint("POINT (30 10)"))', []);
testErrorsAndWarnings('row var = mv_count(to_geopoint(to_geopoint("POINT (30 10)")))', []);
testErrorsAndWarnings('row var = mv_count(to_geoshape(to_geopoint("POINT (30 10)")))', []);
testErrorsAndWarnings('from a_index | where mv_count(dateNanosField) > 0', []);
testErrorsAndWarnings('from a_index | eval var = mv_count(dateNanosField)', []);
testErrorsAndWarnings('from a_index | eval mv_count(dateNanosField)', []);
});

describe('mv_dedupe', () => {
Expand Down Expand Up @@ -4779,8 +4776,6 @@ describe('validation logic', () => {
testErrorsAndWarnings('row mv_first(to_geopoint("POINT (30 10)"))', []);
testErrorsAndWarnings('row var = mv_first(to_geopoint(to_geopoint("POINT (30 10)")))', []);
testErrorsAndWarnings('row var = mv_first(to_geoshape(to_geopoint("POINT (30 10)")))', []);
testErrorsAndWarnings('from a_index | eval var = mv_first(dateNanosField)', []);
testErrorsAndWarnings('from a_index | eval mv_first(dateNanosField)', []);
});

describe('mv_last', () => {
Expand Down Expand Up @@ -4931,8 +4926,6 @@ describe('validation logic', () => {
testErrorsAndWarnings('row mv_last(to_geopoint("POINT (30 10)"))', []);
testErrorsAndWarnings('row var = mv_last(to_geopoint(to_geopoint("POINT (30 10)")))', []);
testErrorsAndWarnings('row var = mv_last(to_geoshape(to_geopoint("POINT (30 10)")))', []);
testErrorsAndWarnings('from a_index | eval var = mv_last(dateNanosField)', []);
testErrorsAndWarnings('from a_index | eval mv_last(dateNanosField)', []);
});

describe('mv_max', () => {
Expand Down Expand Up @@ -5020,8 +5013,6 @@ describe('validation logic', () => {
testErrorsAndWarnings('row nullVar = null | eval mv_max(nullVar)', []);
testErrorsAndWarnings('from a_index | eval mv_max("2022")', []);
testErrorsAndWarnings('from a_index | eval mv_max(concat("20", "22"))', []);
testErrorsAndWarnings('from a_index | eval var = mv_max(dateNanosField)', []);
testErrorsAndWarnings('from a_index | eval mv_max(dateNanosField)', []);
});

describe('mv_median', () => {
Expand Down Expand Up @@ -5159,8 +5150,6 @@ describe('validation logic', () => {
testErrorsAndWarnings('row nullVar = null | eval mv_min(nullVar)', []);
testErrorsAndWarnings('from a_index | eval mv_min("2022")', []);
testErrorsAndWarnings('from a_index | eval mv_min(concat("20", "22"))', []);
testErrorsAndWarnings('from a_index | eval var = mv_min(dateNanosField)', []);
testErrorsAndWarnings('from a_index | eval mv_min(dateNanosField)', []);
});

describe('mv_slice', () => {
Expand Down