[Fleet] Replace all references to unsafe YML load/dump methods in Fleet codebase#190659
Merged
kpollich merged 2 commits intoelastic:mainfrom Aug 19, 2024
Merged
Conversation
kpollich
added
release_note:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Member
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
kpollich
added
backport:prev-minor
and removed
backport:skip
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 21, 2024
…et codebase (elastic#190659) ## Summary Replaces any unsafe YML operations with their safe alternatives. `load` -> `safeLoad` `dump` -> `safeDump` (cherry picked from commit 439c7fa)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 21, 2024
… in Fleet codebase (#190659) (#191015) # Backport This will backport the following commits from `main` to `8.15`: - [[Fleet] Replace all references to unsafe YML load/dump methods in Fleet codebase (#190659)](#190659) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"kyle.pollich@elastic.co"},"sourceCommit":{"committedDate":"2024-08-19T15:35:25Z","message":"[Fleet] Replace all references to unsafe YML load/dump methods in Fleet codebase (#190659)\n\n## Summary\r\n\r\nReplaces any unsafe YML operations with their safe alternatives.\r\n\r\n`load` -> `safeLoad`\r\n`dump` -> `safeDump`","sha":"439c7fa84c45b3c632193ce0ffd16b437ea21e08","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.16.0"],"title":"[Fleet] Replace all references to unsafe YML load/dump methods in Fleet codebase","number":190659,"url":"https://github.com/elastic/kibana/pull/190659","mergeCommit":{"message":"[Fleet] Replace all references to unsafe YML load/dump methods in Fleet codebase (#190659)\n\n## Summary\r\n\r\nReplaces any unsafe YML operations with their safe alternatives.\r\n\r\n`load` -> `safeLoad`\r\n`dump` -> `safeDump`","sha":"439c7fa84c45b3c632193ce0ffd16b437ea21e08"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190659","number":190659,"mergeCommit":{"message":"[Fleet] Replace all references to unsafe YML load/dump methods in Fleet codebase (#190659)\n\n## Summary\r\n\r\nReplaces any unsafe YML operations with their safe alternatives.\r\n\r\n`load` -> `safeLoad`\r\n`dump` -> `safeDump`","sha":"439c7fa84c45b3c632193ce0ffd16b437ea21e08"}}]}] BACKPORT--> Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces any unsafe YML operations with their safe alternatives.
load->safeLoaddump->safeDump