-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Improve column parsing #190612
[ES|QL] Improve column parsing #190612
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Pinging @elastic/kibana-esql (Team:ESQL) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
Summary
Fixes #189913
parts
field to{ type: 'column' }
AST nodes. Theparts
field contains a list of correctly parsed out column framents.text
andname
fields work only if a column does not have any escaped characters. However, I could not change/remove them, as lots of code is currently referring them.Checklist
Delete any items that are not applicable to this PR.
For maintainers