Skip to content

[Discover] Unskip search alert tests #190519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jughosta merged 3 commits into from
Aug 20, 2024
Merged

[Discover] Unskip search alert tests #190519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e824a67
[Discover] Unskip search alert tests
jughosta Aug 14, 2024
4d84a71
[Discover] Update tests
jughosta Aug 19, 2024
8746151
Merge branch 'main' into 190090-unskip-search-source-test
jughosta Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/discover/search_source_alert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const log = getService('log');
const es = getService('es');
const monacoEditor = getService('monacoEditor');
const PageObjects = getPageObjects(['settings', 'common', 'header', 'discover', 'timePicker']);
const PageObjects = getPageObjects([
'settings',
'common',
'header',
'discover',
'timePicker',
'unifiedFieldList',
]);
const deployment = getService('deployment');
const dataGrid = getService('dataGrid');
const browser = getService('browser');
Expand Down Expand Up @@ -325,8 +332,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await titleElem.getAttribute('value')).to.equal(dataView);
};

// FLAKY: https://github.com/elastic/kibana/issues/190090
describe.skip('Search source Alert', () => {
describe('Search source Alert', () => {
before(async () => {
await security.testUser.setRoles(['discover_alert']);

Expand Down Expand Up @@ -527,7 +533,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

await PageObjects.timePicker.setCommonlyUsedTime('Last_15 minutes');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.addRuntimeField('runtime-message-field', `emit('mock-message')`);
await retry.try(async () => {
expect(await PageObjects.unifiedFieldList.getAllFieldNames()).to.contain(
'runtime-message-field'
);
});

// create an alert
await openDiscoverAlertFlyout();
Expand Down
9 changes: 8 additions & 1 deletion ...rverless/functional/test_suites/common/discover_ml_uptime/discover/search_source_alert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'discover',
'timePicker',
'dashboard',
'unifiedFieldList',
]);
const deployment = getService('deployment');
const dataGrid = getService('dataGrid');
Expand Down Expand Up @@ -364,7 +365,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await titleElem.getAttribute('value')).to.equal(dataView);
};

describe('Search source Alert', function () {
describe('Search source Alert', () => {
before(async () => {
await security.testUser.setRoles(['discover_alert']);
await PageObjects.svlCommonPage.loginAsAdmin();
Expand Down Expand Up @@ -562,7 +563,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

await PageObjects.timePicker.setCommonlyUsedTime('Last_15 minutes');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.addRuntimeField('runtime-message-field', `emit('mock-message')`);
await retry.try(async () => {
expect(await PageObjects.unifiedFieldList.getAllFieldNames()).to.contain(
'runtime-message-field'
);
});

// create an alert
await openDiscoverAlertFlyout();
Expand Down