Slim down popover panels

[ryankeairns]

Summary

These couple of popover panels contain more padding than desired or intended by the design system.

Before
Discover alerts popover

Nav deployments popover

After
Discover alerts popover

Nav deployments popover

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Flaky Test Runner was used on any tests changed
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[jughosta]

Data Discovery changes LGTM 👍

[eokoneyo]

Changes look good.

[eokoneyo]

I've got a follow up question here, is the guidance to default padding for popovers to the eui 's' value across the product?

[ryankeairns]

I've got a follow up question here, is the guidance to default padding for popovers to the eui 's' value across the product?

Thanks for the review, that's a keen follow-up question :)

These two examples have long stood out to me as atypical in how much padding they contain; however, they were using the default m padding. The challenge - in my estimation - is the wide variety of child components that can be placed within a popover and the sorts of padding they bring along. That 'internal' padding can be necessary for hover/focus/active states.

At the end of the day, the amount of padding in these menus is very uncommon in the designs I see/review, and we (UX) would typically catch such divergence during PR reviews. I can pass this observation on to the team working on the new theme - perhaps its something we can better control going forward.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: e8525a9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	842.5KB	842.5KB	+30.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
core	419.9KB	419.9KB	+21.0B

History

• 💛 Build #227659 was flaky 389ab3a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ryankeairns