Skip to content

[Security Solution][Entity details] - move code to get url link to flyout folder#190111

Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti:get-url-link
Aug 19, 2024
Merged

[Security Solution][Entity details] - move code to get url link to flyout folder#190111
PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti:get-url-link

Conversation

@PhilippeOberti
Copy link
Copy Markdown
Contributor

Summary

This PR continues the effort in removing all old flyout components, hooks and utils functions. It moves all the code related to retrieving the url to share from the old event_details folder to the alert details expandable flyout folder

The goal of this PR is to:

  • move the code and update the imports
  • add unit tests if they were not present

The purpose of the PR was never to full refactor the code, so things that aren't necessarily super clean might still be present.

No UI changes should be visible whatsoever!

Checklist

https://github.com/elastic/security-team/issues/7462

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.16.0 labels Aug 8, 2024
@PhilippeOberti PhilippeOberti marked this pull request as ready for review August 8, 2024 10:24
@PhilippeOberti PhilippeOberti requested review from a team as code owners August 8, 2024 10:24
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a unit test?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@PhilippeOberti PhilippeOberti force-pushed the get-url-link branch 2 times, most recently from 08e1ed6 to 294b2f3 Compare August 19, 2024 10:25
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5653 5652 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB +292.0B

History

  • 💔 Build #228171 failed 294b2f3b08e9eb944076be4527332377acb4cdc8
  • 💔 Build #228167 failed 08e1ed6a7b31e0fd35cbb6482109afff2ed0ee4f
  • 💚 Build #226438 succeeded fd867d3a143dc7f0dbef1c084b729e058fdf7d10

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

@PhilippeOberti PhilippeOberti merged commit 6d1426a into elastic:main Aug 19, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 19, 2024
@PhilippeOberti PhilippeOberti deleted the get-url-link branch August 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants