Skip to content

[Security Solution][Entity details] - move prevalence related hooks to flyout folder#190109

Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti:analyzer-prevalence
Aug 19, 2024
Merged

[Security Solution][Entity details] - move prevalence related hooks to flyout folder#190109
PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti:analyzer-prevalence

Conversation

@PhilippeOberti
Copy link
Copy Markdown
Contributor

Summary

This PR continues the effort in removing all old flyout components, hooks and utils functions. It moves all the code related to prevalence and process tree for analyzer and other components from commone folders to the alert details expandable flyout folder

The goal of this PR is to:

  • move the code and update the imports
  • add unit tests if they were not present

The purpose of the PR was never to full refactor the code, so things that aren't necessarily super clean might still be present.

No UI changes should be visible whatsoever!

Checklist

https://github.com/elastic/security-team/issues/7462

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.16.0 labels Aug 8, 2024
@PhilippeOberti PhilippeOberti marked this pull request as ready for review August 8, 2024 10:24
@PhilippeOberti PhilippeOberti requested review from a team as code owners August 8, 2024 10:24
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5653 5654 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB +120.0B

History

  • 💔 Build #228151 failed b5ffcdf93947b55ec9b7ab0253f685833c6f5f22
  • 💛 Build #226433 was flaky 019685f88a5b8b830d341f8382c47ab7f62f6cfa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 35c0671 into elastic:main Aug 19, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 19, 2024
@PhilippeOberti PhilippeOberti deleted the analyzer-prevalence branch August 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants