[ResponseOps] Lazy load dataViews and wrappedSearchSourceClient services when running alerting rules#189929
Merged
doakalexi merged 13 commits intoelastic:mainfrom Aug 19, 2024
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
…m:doakalexi/kibana into alerting/lazy-load-dataviews-searchsource
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
…m:doakalexi/kibana into alerting/lazy-load-dataviews-searchsource
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
dominiqueclarke
left a comment
There was a problem hiding this comment.
Obs ux management changes LGTM.
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
dominiqueclarke
approved these changes
Aug 9, 2024
ymao1
approved these changes
Aug 19, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Resolves #184322
Summary
This PR updates
getExecutorServicesto allow alerting rules to only load the dataViews and wrappedSearchSourceClient services when needed. I updated the rule types dependent on dataViews and/or wrappedSearchSourceClient.Checklist
To verify
dataViewsandsearchSourceClientservices are not created.Custom threshold
SLO burn rate
ES query
Indicator match