[Advanced Settings] Add retry for 409 conflicts in API integration tests

[ElenaStoeva]

Fixes #176445

Summary

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6679

This PR fixes the advanced settings API integration tests that seem to be flaky. The reason for the occasional failures is most likely a version_conflict_engine_exception which is thrown when another node indexes the same documents. This can happen when we save an advanced setting since the settings API uses saved objects under the hood, and in CI, multiple nodes can try to save an advanced setting simultaneously.

The solution in this PR is to retry the request if we encounter a 409 error. This is adapted from the solution in #174185 which resolves a similar failure.

[kibanamachine]

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6679

[✅] x-pack/test/api_integration/apis/management/config.ts: 200/200 tests passed.

see run history

[elasticmachine]

Pinging @elastic/kibana-management (Team:Kibana Management)

[sabarasaba]

Thanks a lot for patching this up @ElenaStoeva! Code changes lgtm, the only thing I wanted to get your opinion on is if you think the retry_if_conflicts util might be useful somewhere else at some point? Otherwise might be worth to move to a common folder

[ElenaStoeva]

Thanks for the review @sabarasaba!

the only thing I wanted to get your opinion on is if you think the retry_if_conflicts util might be useful somewhere else at some point? Otherwise might be worth to move to a common folder

Good call! This util may be useful somewhere else but I'm not sure where exactly since this is for a bit specific case where the called API uses saved objects under the hood. I looked into the test directory structure but I didn't find a place where it made sense to me to move this file to. Do you have any specific location in mind?

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 72f73fc

Metrics [docs]

✅ unchanged

History

• 💛 Build #227005 was flaky dbb2e29
• 💛 Build #226283 was flaky a255b11
• 💔 Build #226237 failed b18e976

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

[kibanamachine]

💔 All backports failed

Status	Branch	Result
❌	8.14	Backport failed because of merge conflicts
❌	8.15	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 189813

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 189813 locally

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 189813 locally