[Security assistant] Fix Bedrock Langgraph ESQL tool calling#189810
Merged
andrew-goldstein merged 8 commits intoelastic:mainfrom Aug 2, 2024
Merged
[Security assistant] Fix Bedrock Langgraph ESQL tool calling#189810andrew-goldstein merged 8 commits intoelastic:mainfrom
andrew-goldstein merged 8 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
…hain/graphs/default_assistant_graph/prompts.ts
Reverts change to x-pack/plugins/elastic_assistant/server/lib/langchain/graphs/default_assistant_graph/prompts.ts
Contributor
|
@elasticmachine merge upstream |
andrew-goldstein
added
Team:Security Generative AI
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
andrew-goldstein
added
release_note:skip
patrykkopycinski
changed the title
patrykkopycinski
changed the title
…e-gemini-prompt-update Restores change to the Gemini system prompt
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
peluja1012
approved these changes
Aug 2, 2024
Contributor
peluja1012
left a comment
peluja1012
left a comment
There was a problem hiding this comment.
Tested locally with Sonnet 3.5, Gemini, and gpt-4o. ES|QL generation with Sonnet (Bedrock connector) worked as expected and the ESQL tool was called every time. Also tested the RAG on alerts workflow with these models. There didn't appear to be any regressions with Gemini or gpt-4o on the RAG on alerts or ES|QL generation workflows.
It's worth noting that, as the PR description mentions, it only fixes Bedrock ES|QL generation. Gemini ES|QL generation is still not working well, although, it works better when the default System Prompt is cleared before sending the message.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 2, 2024
…#189810) ## Summary Addresses the Bedrock portion of elastic#189771. When using the Bedrock connector and asking the AI Assistant ES|QL generation questions, the AI Assistant is now consistently using the `ESQLKnowledgeBaseTool` and responding with correct ES|QL syntax. This is an example of a [successful trace](https://smith.langchain.com/o/b739bf24-7ba4-4994-b632-65dd677ac74e/projects/p/34f01a8b-e9a5-4df6-8cc2-163960220718?timeModel=%7B%22duration%22%3A%227d%22%7D&peek=9b7d5f31-c98b-4f63-bb9b-b2df95863218).  (cherry picked from commit 83490a0)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 3, 2024
…189810) (#189845) # Backport This will backport the following commits from `main` to `8.15`: - [[Security assistant] Fix Bedrock Langgraph ESQL tool calling (#189810)](#189810) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2024-08-02T23:47:27Z","message":"[Security assistant] Fix Bedrock Langgraph ESQL tool calling (#189810)\n\n## Summary\r\n\r\nAddresses the Bedrock portion of https://github.com/elastic/kibana/issues/189771.\r\n\r\nWhen using the Bedrock connector and asking the AI Assistant ES|QL generation questions, the AI Assistant is now consistently using the `ESQLKnowledgeBaseTool` and responding with correct ES|QL syntax. This is an example of a [successful trace](https://smith.langchain.com/o/b739bf24-7ba4-4994-b632-65dd677ac74e/projects/p/34f01a8b-e9a5-4df6-8cc2-163960220718?timeModel=%7B%22duration%22%3A%227d%22%7D&peek=9b7d5f31-c98b-4f63-bb9b-b2df95863218).\r\n\r\n","sha":"83490a0a3e70b7514918bf98263c96030a3939fd","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team: SecuritySolution","ci:cloud-deploy","Team:Security Generative AI","v8.15.0","v8.16.0"],"title":"[Security assistant] Fix Bedrock Langgraph ESQL tool calling","number":189810,"url":"https://github.com/elastic/kibana/pull/189810","mergeCommit":{"message":"[Security assistant] Fix Bedrock Langgraph ESQL tool calling (#189810)\n\n## Summary\r\n\r\nAddresses the Bedrock portion of https://github.com/elastic/kibana/issues/189771.\r\n\r\nWhen using the Bedrock connector and asking the AI Assistant ES|QL generation questions, the AI Assistant is now consistently using the `ESQLKnowledgeBaseTool` and responding with correct ES|QL syntax. This is an example of a [successful trace](https://smith.langchain.com/o/b739bf24-7ba4-4994-b632-65dd677ac74e/projects/p/34f01a8b-e9a5-4df6-8cc2-163960220718?timeModel=%7B%22duration%22%3A%227d%22%7D&peek=9b7d5f31-c98b-4f63-bb9b-b2df95863218).\r\n\r\n","sha":"83490a0a3e70b7514918bf98263c96030a3939fd"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189810","number":189810,"mergeCommit":{"message":"[Security assistant] Fix Bedrock Langgraph ESQL tool calling (#189810)\n\n## Summary\r\n\r\nAddresses the Bedrock portion of https://github.com/elastic/kibana/issues/189771.\r\n\r\nWhen using the Bedrock connector and asking the AI Assistant ES|QL generation questions, the AI Assistant is now consistently using the `ESQLKnowledgeBaseTool` and responding with correct ES|QL syntax. This is an example of a [successful trace](https://smith.langchain.com/o/b739bf24-7ba4-4994-b632-65dd677ac74e/projects/p/34f01a8b-e9a5-4df6-8cc2-163960220718?timeModel=%7B%22duration%22%3A%227d%22%7D&peek=9b7d5f31-c98b-4f63-bb9b-b2df95863218).\r\n\r\n","sha":"83490a0a3e70b7514918bf98263c96030a3939fd"}}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the Bedrock portion of #189771.
When using the Bedrock connector and asking the AI Assistant ES|QL generation questions, the AI Assistant is now consistently using the
ESQLKnowledgeBaseTooland responding with correct ES|QL syntax. This is an example of a successful trace.